Closed sseppi closed 1 month ago
@pkritzinger @gappc What do you think? It would be nice to discuss a possible solution in the next refinement meeting and implement it as soon as possible, since the request came from a user that is actually using the Data Browser.
@sseppi @gappc honestly, I lack technological know-how here. What does a "null"-value mean in detail? Is it something like "not defined"?
@sseppi @gappc honestly, I lack technological know-how here. What does a "null"-value mean in detail? Is it something like "not defined"?
@pkritzinger yes, a null value means that the field is empty. In this case specifically it hasn't any status (neither true or false) assigned.
@sseppi ok, but then we should set null as default and provide a dropdown to to the user to select between the different options (null, false, true)
fyi @gappc
During the Refinement Meeting it has been decided, to keep the 3 levels and use "null" as default value.
@pkritzinger will now think a possible graphical solution to manage the 3 values (true, false and null)
@sseppi @gappc what do you think of this solution?
I like :)
@pkritzinger I like it too.
Since null is a technical term that is dissicult to understand for non technical users, I would propose only a change of name and to keep also the color status as follows:
What do you think? If you agree, I think we are ready to implement this feature.
@sseppi you mean like this?
Honestly, not sure if this does not get too colorful. Would stick to the original (green suggestion.).
@pkritzinger I meant to color the whole switcher, also the border, like we do with the actual switcher (see screenshot below).
But I let you decide, which is the best solution to be applied.
@sseppi like this?
Not sure if that works, we would have a constant change of font colors as well. I'm afraid that looks weird when interacting with the toggle. I would honestly stick to the previous solution.
@sseppi like this?
Not sure if that works, we would have a constant change of font colors as well. I'm afraid that looks weird when interacting with the toggle. I would honestly stick to the previous solution.
@pkritzinger fine for me.
@sseppi find the link to the design here: https://www.figma.com/design/DmuP6Dbv5LzkCNOXrDnWIL/2023-2024?node-id=3400-2726&t=Aqc1LTBFLNznyqoc-1
@pkritzinger during the meeting we decided to use undefined instead of null
@sseppi wording has been updated, see link to design below:
https://www.figma.com/design/DmuP6Dbv5LzkCNOXrDnWIL/2023-2024?node-id=3400-2726&t=0puXalq3WZ4uGn3o-1
@RudiThoeni when this 3-state toggle is set to "Undefined", should the value that gets written, be undefined
or null
?
@sseppi, @mrabans @pkritzinger, @Mazzolintis, @RudiThoeni here you can try out the first implementation: https://1.databrowser.gappc.net/dataset/edit/tourism/v1/Article/BCCEEEC0-739A-90F3-F0E8-268816DBAD48 (see first image below)
Things to note:
undefined
(@RudiThoeni is this correct?). The difference to the current Toggle
component is:
Toggle
component shows wrongly a value of false
if nothing is selected)undefined
/ null
intentionallyPlease take a look and let me know what you think.
@gappc Thank you for the fast implementation
In my point of view the "undefined" status of the toggle corresponds to the "Null" value in the database. For that reason I would propose to write "Null" in case the user selects "undefined" and use that status as default status.
@RudiThoeni do you agree?
@gappc @sseppi yes let's write null
PR merged issue closed
I tested the component and everything seems to work fine. Close the issue.
Thanks to the feedback of a user, we noticed that the default value of all toggle elements seems to be misleading. Once the user creates a new record all toggle are set to false per default but in the JSON is stored null value. To store a false value the user has to click twice on the toggle to activate it and de-activate it. This seems to be not user friendly, since the user sees the toggle set on false per default.
Steps to replicate the issue
"Active": true
"Active": false
User expectation
The user, since sees the toggle inactive (red) per default expects that the value is stored false per default.
Possible solutions
true
,false
andinactive/null
false
per default