search

noi-techpark / odh-docs

Open Data Hub (http://opendatahub.com/) Documentation
http://opendatahub.readthedocs.io/en/latest/index.html
4 stars 4 forks source link

Issue 125 new authentication #133

Closed stefanodavid closed 4 years ago

Piiit commented 4 years ago

@stefanodavid There is no description of the actual usage of Keycloak... we need a minimal example (with curl for instance) to show how to get closed data IMO.

In addition we should think of splitting mobility v1 and v2 within this chapter. Or would that description be another PR?

We need also to explain the difference between mobility v2 and tourism... which are not many, the first part regarding getting a token is the same...

I could take this PR in in the meantime and we add to it with another PR, or do you prefer to release all together?

stefanodavid commented 4 years ago

@Piiit in the issue there was no mention of an howto, you rather wrote

Since this is very technical and depends on various factors, writing a whole section inside RTD wouldn't be feasible, hence we decided to just point to three things:

So I think I wrote in this PR exactly what you asked for...

About your other comments about v1/v2/mobilty/tourism differences, I think this information should be written elsewhere.

Piiit commented 4 years ago

@stefanodavid You are right, I confused the API consumer authentication with the developer one. And I confused that already twice, then I closed #118 and let #125 supersede it, but at the end these are two different issues. So sorry for the confusion... I will not reopen #118 now, but we should then add a "How to retrieve closed data from an API v2 as an API consumer" or similar chapter somewhere. I better open a new issue for that... not to mix issues again....