search

noi-techpark / odh-docs

Open Data Hub (http://opendatahub.com/) Documentation
http://opendatahub.readthedocs.io/en/latest/index.html
3 stars 4 forks source link

ODH Tourism available Datasets Change Request #155

Closed RudiThoeni closed 3 years ago

RudiThoeni commented 4 years ago

Hi Stefano

For: https://opendatahub.readthedocs.io/en/latest/datasets.html#datasets-in-the-tourism-domain we have following Change Requests

1) -Remove it.bz.siag.museum it.bz.siag.weather

--> we will only describe datasets available directly on the Opendatahub Tourism Api.

2) -Change I adapted the changes in the Sheet but you can also use as "master" for the available tourism data

https://tourism.opendatahub.bz.it/api

I've inserted the same Id as in the sheet a Description, a SwaggerURL and a License Information

Please add also this link https://tourism.opendatahub.bz.it/api in the description and mention that the api is browsable,

thx and if you have questions write me

Rudi

stefanodavid commented 4 years ago

@RudiThoeni I removed the link to the document as it appears freely editable and I am not sure this is intended. Please check the permissions.

I would also splint the issue in three, because actually the three changes you require are unrelated.

stefanodavid commented 4 years ago

@RudiThoeni what about sasabus dataset?

RudiThoeni commented 4 years ago

@rcavaliere Patrick said we should ask you about this.... on the tourism dataset we remove the external apis like the siag weather api and the siag museum api...... stefano asks about the sasabus api if he also should remove it from the documentation?

RudiThoeni commented 4 years ago

@RudiThoeni I removed the link to the document as it appears freely editable and I am not sure this is intended. Please check the permissions.

I would also splint the issue in three, because actually the three changes you require are unrelated.

You have read and write access to this document ;)

splitting the issues in 3 is good for me.

rcavaliere commented 4 years ago

@RudiThoeni please wait until next Monday, we will discuss this with SASA in a meeting

stefanodavid commented 4 years ago

@RudiThoeni yes, I have access, but everybody has read and download access just with the link. Not sure this is intended...

RudiThoeni commented 4 years ago

ah now i understand you removed it from github ;) ok perfect! we will check the permissions of this document.......

stefanodavid commented 4 years ago

@RudiThoeni I think that most of this issue will be tackled by the new issue #156, which is more general and foresees changes for almost all datasets.

RudiThoeni commented 4 years ago

ok so i close this

stefanodavid commented 4 years ago

That's fine @RudiThoeni but remember to tell me what should I do with the sasabus dataset

RudiThoeni commented 4 years ago

@rcavaliere i think sassabus dataset should remain, right?

rcavaliere commented 4 years ago

@RudiThoeni @stefanodavid please still wait for a while here. We are in negotiations with SASA...

RudiThoeni commented 3 years ago

Hi stefano what about this CR ;)

stefanodavid commented 3 years ago

Hi stefano what about this CR ;)

@RudiThoeni I completely forgot about it :blush: :sob: I am going to work on it right now.

stefanodavid commented 3 years ago

@RudiThoeni I will not add license information for now, because as you know there is an ongoing discussion about this topic and I will discuss the topic with Martin next week.

About the descriptions, almost all were already added (see #156) and we keep them on a shared presentation (ask Emily or Martin), so I will not use them.

About the link to the API I have a few questions before adding them: 1) In the mobility we have link to browsable API only, not swagger URLs. Should be keep for tourism also swagger or replace swagger with link to browsable API? 2) In case we go for both, should we add swagger to Mobility as well? 3) Why for mobility the API link is https://mobility.api.opendatahub.bz.it/ and for tourism is https://tourism.opendatahub.bz.it/api/ ? :-) Let's clear points 1) and 2) before I go any further.

RudiThoeni commented 3 years ago

Hi Stefano

1) + 2) I would go for both. SwaggerURL and Api URL for both mobility and tourism On the mobility has to be included the information that there is only 1 swagger, not 1 swagger per Endpoint.

3) Because of current system architecture (tourism.opendatahub.bz.it opens the Databrowser) this maybe changes in the future but not now....

lg Rudi

stefanodavid commented 3 years ago

@RudiThoeni I added the API URLs to all datasets that are now present in the docs. Please double check the linked PR :-)