Closed stefanodavid closed 2 years ago
@mrabans please check and merge if possible... Thx
@stefanodavid @mrabans I merge this now, looks good. However, I find it always hard to just grasp the whole changes with the PR view here, we really need to have a testing environment in place... on our to-do since forever, but still, would be a really nice-to-have :-)
@stefanodavid @Piiit that it exactly the reason why it takes me always so long to review these changes.
@stefanodavid @mrabans I merge this now, looks good. However, I find it always hard to just grasp the whole changes with the PR view here, we really need to have a testing environment in place... on our to-do since forever, but still, would be a really nice-to-have :-)
@piiit @mrabans I opened a ticket for this on May 2021, but apparently nobody has found 10 minutes to look into this and fix it. I can put up on my personal VPS a testing enviroment if you want.
@mrabans @sseppi can you check the PR and let @Piiit or @RudiThoeni merge it? Thanks in advance!