search

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

As a project manager I would like to adapt the application for the domain mobility.bz.it #118

Closed rcavaliere closed 2 years ago

rcavaliere commented 2 years ago

We also host the domain https://mobility.bz.it/ It was actually the version of mobility.meran.eu but "adapted" for the Municipality of Bolzano. Our idea is to make something similar as for the Merano domain, i.e. if we access from this domain you get access to the same application but with some adaptations. In particular:

Citta_BZ

stefanocudini commented 2 years ago

@rcavaliere should the above logo replace this?

and page title: "Bolzano - Alto Adige/Suedtirol" or "Bolzano - Real time bus"

rcavaliere commented 2 years ago

@stefanocudini yes exactly. Where is the page title displayed?

stefanocudini commented 2 years ago

at top left. I'm slightly resizing the image logo for sizes limits

stefanocudini commented 2 years ago

this solved and included in PR #134

to customize title for each domain, you can act here: in file /joruney/config.yml (any changes require a docker rebuild of journey) https://github.com/noi-techpark/odh-mentor-otp/blob/8b8bd831add94614fcd490bbc7bfa61384a609c8/journey/config.yml#L26-L30 for example here the title(brandNavbar) is empty '' and navigation bar on top of page contains only logo

some other customizations by domain name can be applyed here, for example map initial location and zoom https://github.com/noi-techpark/odh-mentor-otp/blob/8b8bd831add94614fcd490bbc7bfa61384a609c8/journey/config.yml#L38-L43

rcavaliere commented 2 years ago

However if I go to mobility.bz.it. I still get opened the old application. @RudiThoeni did we integrate this in the productive development and made a rebuild of the application?

RudiThoeni commented 2 years ago

hi rcavaliere, did not know about this....... i have to redirect the domain to the new application, and deploy the latest PR to production currently it is only on dev? i always wait for your ok to deploy it on prod ;)

rcavaliere commented 2 years ago

@RudiThoeni should be this PR: https://github.com/noi-techpark/odh-mentor-otp/pull/134 @stefanocudini right? If yes, please proceed. For the moment I won't put into production the travel times functionality (see PR https://github.com/noi-techpark/odh-mentor-otp/pull/135)

RudiThoeni commented 2 years ago

@rcavaliere yes i deployed PR134 on production and redirected mobility.bz.it, maybe the zoom level should be increased because the stops are visible when you zoom in one step....

The logo works, the gps coordinates where to set center works, only the site title is not taken, it still shows merano

RudiThoeni commented 2 years ago

Here i think there is a little bug https://github.com/noi-techpark/odh-mentor-otp/blob/master/journey/config.yml#L33 always the default title Merano is taken

rcavaliere commented 2 years ago

@RudiThoeni thanks, agree with your comment on the zoom level. But I don't know if this can be adapted for the different URLs... @stefanocudini can you provide a feedback on that?

RudiThoeni commented 2 years ago

yes it is here ;) 

configByDomain: 
   mobility.bz.it: 
     map: 
       initLat: 46.492111111111 
       initLon: 11.333333333333 
       initZoom: 14
stefanocudini commented 2 years ago

maybe the zoom level should be increased because the stops are visible when you zoom in one step....

yes this behavior is intended to show the stops only when there is a sufficient zoom level otherwise they are too close

instead, the initial zoom for the mobility.bz.it domain can be adapted to ensure that stops are immediately visible, initZoom:15

stefanocudini commented 2 years ago

Here i think there is a little bug https://github.com/noi-techpark/odh-mentor-otp/blob/master/journey/config.yml#L33 always the default title Merano is taken

@RudiThoeni yes I noticed this little bug I have the solution are a few lines .... but from some branch can I send you a PR for this thing? our fork (development branch) now includes also the traffic layer.

if it is not an urgent thing I can include it together with the next PR which also includes changes on the traffic layer

RudiThoeni commented 2 years ago

the best is if this is inside the next PR with changes on traffic layer... otherwise we have a some confusion and we have to cherry pick commits to deploy etc.... @rcavaliere when are we ready to deploy also the traffic layer on production?

stefanocudini commented 2 years ago

about this I will add details under dedicated PR to the traffic layer #135