noi-techpark / odh-mentor-otp

4 stars 8 forks source link

A.2.2 New OTP build with full GTFS #14

Closed rcavaliere closed 3 years ago

rcavaliere commented 3 years ago
rcavaliere commented 3 years ago

Good news: we got today the full GTFS export, available here: https://cloud.opendatahub.bz.it/index.php/s/j9MpiMz3DEDwtgs Let's discuss today how to organize the new OTP build

bertolla commented 3 years ago

@rcavaliere I let the script run yesterday with the new data. I'm not sure the outcome is as expected. In any case I downloaded the logfile of the calculation if needed. See https://journey.opendatahub.testingmachine.eu/

rcavaliere commented 3 years ago

@bertolla I don't think that we are now seing the data provided by the new GTFS export... can you provide us some more details of the results you obtained at the end of the build?

bertolla commented 3 years ago

I took the zip file you uploaded ~111MB and replaced it(I renamed it to fit the original to avoid to change the pipeline) in the data folder. I run the calculations for the new Graph and according to the log files it got included for the calculations.

rcavaliere commented 3 years ago

@bertolla I am not sure that the client now shows the new GTFS export yet. @zabuTNT @stemove can you confirm this? I would proceed in that way:

zabuTNT commented 3 years ago

Hi @rcavaliere @bertolla , the graph is the old one, with old data. If you go here: https://otp.opendatahub.testingmachine.eu/otp/routers/openmove/

you can see the build graph date: <buildTime>1603729881302</buildTime> so: 26/10/2020

And again if you go here: https://otp.opendatahub.testingmachine.eu/

you can plan a test travel from A to B (free to possible constrains of our webapp) , and you will see that there are no shapes in response. 2020-11-09-104557_883x800_scrot

bertolla commented 3 years ago

I thought so, but I checked and the last graph in the data folder was created on 5. Nov. See: Screenshot from 2020-11-09 12-52-09

Maybe the small otp instance needs to restart to make it available or some other kind of trigger to use the new generated graph.

bertolla commented 3 years ago

I restarted the instance and now it's working. So I guess we need to trigger the loading in memory of the new graph to the live otp instance or we won't see when graph update.

rcavaliere commented 3 years ago

@bertolla nice, now it's seems to be the right GTFS file. But we stil don't see bikesharing data integrated, isn't @zabuTNT and @stemove?

bertolla commented 3 years ago

One step after another. I'm doing it like this:

bertolla commented 3 years ago

I guess we can trigger the reload by doing a simple put on this endpoint after graph calculation. I tried with curl, and it worked: curl -i -X PUT -H 'Content-Type:applicaton/json' "https://otp.opendatahub.testingmachine.eu/otp/routers/openmove" Meanwhile I will do this through the pipeline.

bertolla commented 3 years ago

The bikesharing data is in another issue

zabuTNT commented 3 years ago

hi @bertolla, don't use PUT in order to reload the graph. That opens OTP to security issues.

With the new pull request otp starts with the autoreload graph detector, and without the possibility to use PUT/DELETE/POST (for security reasons).

You don't have to reload the graph manually (you have to relaunch the container that runs OTP, so it will start with the autoreload parameter). https://github.com/noi-techpark/odh-mentor-otp/blob/development/infrastructure/docker/otp/docker-entrypoint.sh#L120

bertolla commented 3 years ago

Nice didn't know about that. I will undo that change and redeploy. Thanks