search

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

fix journey geocoder #157

Closed stefanocudini closed 1 year ago

stefanocudini commented 1 year ago

small fix that solves a problem in the journey results menu

rcavaliere commented 1 year ago

@stefanocudini thanks! Since you are active on this, can you please provide a feedback on #75 ?

RudiThoeni commented 1 year ago

@rcavaliere i deployed on test, if you want to do a quick check let me know if everything ok so i can proceed with the production deploy

rcavaliere commented 1 year ago

@RudiThoeni thanks! But this PR does not contain the configuration of the HERE geocoder, isn't it? @stefanocudini can you please provide a feedback on #75? We have seen that HERE has changed something in the usage of its geocoder....

stefanocudini commented 1 year ago

with this PR, I think this solve the problem: https://github.com/noi-techpark/odh-mentor-otp/pull/158

the Here API have been changed since we opened the issue https://github.com/noi-techpark/odh-mentor-otp/issues/75 many months ago.

our AppCode that we use in the tests of our fork are continuing to work without problems. But I made this change in the geocoder module to support AppKey because it is useful for the future also for our fork. Now only appKey is required in the environment variables (_HEREAPIKEY)

but I would ask you to fix by yourself the part concerning the management of the environment variable in the folder of your infrastructure

rcavaliere commented 1 year ago

@stefanocudini perfect! @RudiThoeni you can integrate the PR, I will provide the APIKEY in a separate way for your ingestion.

@stefanocudini just another think, am I wrong or in this moment we don't have real-time data? It's a matter of the GTFS-Realtime stream we are using, or it is something related to our implementation?

RudiThoeni commented 1 year ago

integrated