search

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

EPIC: As Open Data Hub manager I would like to integrate car pooling services in the v2 OTP instance #174

Open rcavaliere opened 5 months ago

rcavaliere commented 5 months ago

Currently car pooling trips shared by ummadum (currently limited to South Tyrol) are available through the testing environment of the Open Data Hub through this API: https://mobility.api.opendatahub.testingmachine.eu/v2/flat,node/CarpoolingTrip/*/latest

rcavaliere commented 4 months ago

Open Topics:

rcavaliere commented 4 months ago

Replies to open topics, relevant for @hbruch:

rcavaliere commented 4 months ago

@hbruch @leonardehrenfried the Swagger of the Open Data Hub Mobility API, including description of the available fields and filtering options in the API calls, is available here: https://swagger.opendatahub.com/?url=https://mobility.api.opendatahub.com/v2/apispec#/Mobility%20V2

In case of need of further clarifications, please let us know

hbruch commented 4 months ago

When requesting only active CarpoolingTrips, I get two trips with sactive=true, though in the past. Shouldn't they be inactive?

{
      "_timestamp": "2024-01-11 04:30:00.086+0000",
      "tdescription": "itinerary_details",
      "tmetadata": {},
      "tname": "itinerary_details",
      "ttype": "Instantaneous",
      "tunit": "json",
      "mperiod": 3600,
      "mtransactiontime": "2024-01-04 04:40:07.072+0000",
      "mvalidtime": "2024-01-11 04:30:00.086+0000",
      "mvalue": {"status": "PUBLISHED", "end_post_code": "39021", "seats_reserved": 0, "start_post_code": "39100", "ride_distance_km": 56.9, "start_lat_approx": 46.49, "start_lon_approx": 11.36, "ride_start_at_UTC": "2024-01-10T16:30Z", "ride_created_at_UTC": "2024-01-03T22:01:18Z", "ride_duration_minutes": 54.0},
      "prlineage": "UMMADUM",
      "prname": "odh-mobility-dc-carpooling",
      "prversion": "c50134a38601c73fa33d95533e1329792eafd065",
      "sactive": true,
      "savailable": true,
      "scode": "cd2beb0dd88ead7a0e16bb41a2221d1d",
      "scoordinate": {
        "x": 11.36,
        "y": 46.49,
        "srid": 4326
      },
      "smetadata": {"end_lat_approx": 46.62, "end_lon_approx": 10.85, "start_lat_approx": 46.49, "start_lon_approx": 11.36},
      "sname": "UMMADUM_1",
      "sorigin": "UMMADUM",
      "stype": "CarpoolingTrip"
    }

It seems that value has no UMMADUM specific ID, right? scode seems to be the datahub Id for the CarpoolTrip, the numeric suffix of sname could be an ID, but is not unique, so apparently not(?)

dulvui commented 4 months ago

@hbruch Thank you for the info! Now I discovered an issue with the datacollector: when no trips are available, the old active ones don't get set to active = false and I will fix this issue asap

dulvui commented 4 months ago

@hbruch The issue is fixed now and now no carpooling trips show up anymore with active=true as expected.

rcavaliere commented 4 months ago

@hbruch two updates on my side:

dulvui commented 3 months ago

The carpooling integration is now complete and the routes are visible on the new frontend https://otp-react-redux.opendatahub.testingmachine.eu/#/route/amarillo:ummadum:3999a83091a25bf8e9457934b1b6586a

The carpooling still doesn't show up as options when searching for a trip, but that is related to the frontend, since after a quick check in the code it seems that it doesn't support carpooling yet. The GTFS file is available here https://amarillo.otp.opendatahub.testingmachine.eu/gtfs/amarillo.altoadige.gtfs.zip Should I also integrate it to our https://gtfs.api.opendatahub.com/ GTFS API?

@rcavaliere Should @hbruch still participate in the sprint meeting in friday?

rcavaliere commented 3 months ago

@dulvui looks promising! I will have a deeper look into the work, and how the data conversion into GTFS has been done. After that, let's put the GTFS in our API. In the meantime, set up gtfs.api.opendatahub.testingmachine.eu @hbruch I don't think your presence is necessary tomorrow, I think we should now check in detail your work and in case let you in case of open points

dulvui commented 2 months ago

@rcavaliere I was able now to see a carpooling from CityClinic to Caldaro. Here the link and a screenshot to the trip https://otp.opendatahub.testingmachine.eu/?module=planner&fromPlace=46.4704636%2C11.3175522&toPlace=46.41212081413345%2C11.237726211547853&time=6%3A40pm&date=04-11-2024&mode=CARPOOL%2CWALK&arriveBy=false&wheelchair=false&showIntermediateStops=true&locale=en&baseLayer=OSM%20Standard%20Tiles

Image