search

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

sta GTFS feed parent station IDs not conform to IFOPT spec #186

Open hbruch opened 3 months ago

hbruch commented 3 months ago

According to the IFOPT standard (EN 28701:2012, see also https://wiki.openstreetmap.org/wiki/Key:ref:IFOPT), the IFOPT ID should start with first two letters Country Code.

Currently The sta GTFS declares parent stations with stop_ids like Parentit:...:

"it:22021:1060:1:2790","Velturno, Castello","46.6703839725599","11.6009552752191","","Parentit:22021:1060"

IMHO, the parent station should have an ID of it:22021:1060, and if there are Trips which refer to this as stops in the stop_times, a new (unspecific) dummy quay should be introduced like e.g. it:22021:1060:na:na

rcavaliere commented 3 months ago

@hbruch can you please provide me an example of file in which such IDs are present? We typically only have compliant IDs in South Tyrol!

hbruch commented 3 months ago

Technically, it is "compliant" in a sense that the feed's structure is ok (parent stations have correct location code and are not referenced as stop_times). Nevertheless https://gtfs.api.opendatahub.com/v1/dataset/sta-time-tables/raw uses Parentit:... stop_ids in stops.txt.

This is IMO a custom way to assign IDs to parent stations which will I expect not to be done by other operators and hence will result in issues when merging feeds with other Italian or European feeds.

rcavaliere commented 3 months ago

@hbruch ah you are right! It's the file stops.txt. That's clearly a bug. I will manage the issue with the Data Provider (STA). Thanks for highlighting this!