Development - Githubissues

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

Development #51

Closed stefanocudini closed 3 years ago

stefanocudini commented 3 years ago

new environment var CARSHARING_HOST in container build
i18n in singlepage application shift language without reload page
new path for languages files is here: https://github.com/openmove/odh-mentor-otp/tree/development/journey/app/lib/i18n
in languages files DE/IT added new strings to translate, intial with $_key_text complete version is in EN file
geocoder results support multilanguage based on user selection

required rebuild of geocoder and journey images

bertolla commented 3 years ago

@stefanocudini The first commit is the same as last time. Can you rewrite it?

zabuTNT commented 3 years ago

@bertolla I think that is not possibile rebase the commit cause the other branches and partecipants. Every branch should be rebased on every user local repo. Maybe you can rebase it after the merge only on your repo? But I'm not so sure that could work.

stefanocudini commented 3 years ago

I'm sorry @bertolla we have problems and remove the commit at the moment because it remained on other cloned and merged branches. What we can do and send new PRs that may hide the problem..

If you can merge this PR I will send quincly a new PRs where I can add some i18n translations