search

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

As an end-user I would like to see a "credits" button through which it is possible to see what the demonstrator is about, who has developed it, which are the partners, who has financed it, etc. #65

Closed rcavaliere closed 2 years ago

rcavaliere commented 3 years ago

Should be similar to what currently implemented on mobility.meran.eu (see "About" - bottom right)

rcavaliere commented 2 years ago

First prototype available. JSON should be transformed in a HTML page so to manage both contents (multilingual) and images (logo), which should be same for the same languages and be available as common resources

rcavaliere commented 2 years ago

@stefanocudini the credits page looks good! Can you provide me some detail on how we can put content there (texts + logos)?

stefanocudini commented 2 years ago

@rcavaliere now that you've merged the PR, I've made some simplifications in the code to make it easier to edits in the credits section.

in this position: https://github.com/noi-techpark/odh-mentor-otp/blob/development/journey/app/lib/components/app/modal-credits.js#L23 you can insert html with links and logos. Now it contains a basic structure that could be useful to follow to avoid mobile display problems.

to insert new logos, png / jpg files must be placed in this directory: https://github.com/noi-techpark/odh-mentor-otp/tree/development/journey/app/lib/images/credits

and then inserted at the beginning of the credits file the references to the images as in the example comments here: https://github.com/noi-techpark/odh-mentor-otp/blob/development/journey/app/lib/components/app/modal-credits.js#L8 <img src={imageLogo2} />, <img src={imageLogo3} />

rcavaliere commented 2 years ago

OK, now it's my turn to put contents here. Will let you know in case of problems.

rcavaliere commented 2 years ago

@stefanocudini I would like to make also the Interreg logo of Mentor in the credits being clickable. I have tried like this:

https://github.com/noi-techpark/odh-mentor-otp/blob/82728c76cbb31a61e4ed24ba1c22efe743fddfa0/journey/app/lib/components/app/modal-credits.js#L34

but it seems not to work.

How should I adjust it to have the desired effect?

stefanocudini commented 2 years ago

@rcavaliere after the <img > close tag </a> is required

I can fix this in the next PR.

rcavaliere commented 2 years ago

Ok, already seen. Thanks!