As an end-user I expect to have a more user-friendly when searching for an origin / destination

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

As an end-user I expect to have a more user-friendly when searching for an origin / destination #75

Closed rcavaliere closed 1 year ago

rcavaliere commented 2 years ago

Having POIs suggestion is very good, but probably this is not sufficient for normal users. I think most users would try to insert a normal address, and they expect that this is somehow recognized and taken into account. Suggestion is to improve the geocoder so to resolve addresses by using an available free online service. Tasks to be foreseen:

[x] analysis of the available solutions and choice
[x] implementation of the improvement
[x] HERE API key configuration by @rcavaliere
[x] trip planner search optimization (categories orders', number of results, categories' icons)

rcavaliere commented 2 years ago

To discuss during next meeting. Possibilities:

Pelias (service for fee)
HERE (evaluate freemium model)

stefanocudini commented 2 years ago

I'm testing the integration with HERE api for geocoding, these need to generate an appID and appCode related to the mentor instance, which you can generate by following this guide: https://developer.here.com/tutorials/getting-here-credentials/#signing-up-and-getting-your-api-key

freemium limits is here: https://developer.here.com/pricing

I'll make sure you can put the keys in new environment variables

rcavaliere commented 2 years ago

https://developer.here.com/pricing#plan-details

stefanocudini commented 2 years ago

about the fourth point of this issue, I solved the categorie's icons based on the search source data, I will post this in the next PR: geocoder_icons

and max of results are now 20 by default (configurable value) results

rcavaliere commented 2 years ago

@stefanocudini finally we would like to take again in the hands the whole OTP project. One of the first improvement we would like to do, is to activate the HERE geocoder. Is it correct that to activate this we just need this configure the APPID and APPCODE here https://github.com/noi-techpark/odh-mentor-otp/blob/main/geocoder/config.yml ?

stefanocudini commented 2 years ago

@rcavaliere yes, you only need APPID and APPCODE

APPKEY is not required for the type of calls that are implemented now.

here are explained the steps for the generation: https://developer.here.com/documentation/identity-access-management/dev_guide/topics/plat-using-apikeys.html

Piiit commented 2 years ago

@RudiThoeni FYI

rcavaliere commented 1 year ago

I have finally registered and created an APPID. I have seen that it is not possible to create an APPCODE, see https://developer.here.com/documentation/identity-access-management/dev_guide/topics/dev-appcode.html I have instead created an APPKEY that we probably need to use. @stefanocudini can you check if we need to adapt something since HERE does not support APPCODE anymore? @RudiThoeni how should you pass these credentials in a secure way?

rcavaliere commented 1 year ago

@RudiThoeni in testing seems to work fine. Let's put this new version in production!

RudiThoeni commented 1 year ago

done