search

noi-techpark / odh-mentor-otp

4 stars 8 forks source link

update about onDemand #95

Closed stefanocudini closed 2 years ago

stefanocudini commented 2 years ago
rcavaliere commented 2 years ago

@stefanocudini is this PR already complete? It seems to me that the tooltip has been improved as agreed today. Please let us know when this development is from your side complete. By the way, I see that there is one check failed

RudiThoeni commented 2 years ago

Hi I added some missing variables to the CI jenkinsfile and now it's working.........

For next week please tell me what i have exactly to do @rcavaliere mentioned some graph rebuilding, calculating stuff

In the readme i have seen "In OpenTripPlanner is not allowed running a graph built with a different version. In case you change the OpenTripPlanner version or switch from/to Ufficial/IBI-Group Version you have to rebuild the graph." But as far as i understood docker-compose up build rebuilds the graph?

So i think starting job defined in infrastructure/Jenkinsfile-Test-Execute.groovy should do it.... and then start a calculation with infrastructure/Jenkinsfile-Trigger-Graph-Calculation.groovy does this recalculation Please tell me if my assumptions are wrong,

stefanocudini commented 2 years ago

hi @RudiThoeni as for the scripts inside /infrastructure we have no way to test them or understand how they work, over time we have only added new env vars necessary for each service.

development side we only use docker-compose.yml

what you assume is right, as you see in the docker-compose.yml the otp service and build use the same image openmove_otp:latest (defined here infrastructure /infrastructure/docker/otp/Dockerfile)

we usually indicate at each PR which images need a rebuild, in this case I think it is necessary to do a rebuild of all the images first to be sure they are aligned with the latest developments.

Then run the container build which overwrites the /data/openmove/Graph.obj file. The otp container is waiting for changes on this file so it does not need a reboot.

the basic principle is that you need to run the container build after every time the openmove_otp image is rebuilt or data GTFS is changed, but our PR almost never requires to rebuild the openmove_otp image.