noi-techpark / opendatahub-website

0 stars 6 forks source link

Should we add a browser icon for the open data hub website? #215

Closed d3liaa closed 3 months ago

d3liaa commented 11 months ago

I just noticed there isn't one. We could easily use the open data hub logo in black or white :)

sseppi commented 11 months ago

I agree with you @delia.

Il 16 ott 2023 17:00, Delia Mennitti @.***> ha scritto:

I just noticed there isn't one. We could easily use the open data hub logo in black or white :)

— Reply to this email directly, view it on GitHubhttps://github.com/noi-techpark/opendatahub-website/issues/215, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4LEZK7EZPAW7QIIH7XPQTX7VDYHAVCNFSM6AAAAAA6CK6RHSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DKNBTG4YDGNQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ohnewein commented 9 months ago

Hi all I noticed the same issue.

https://opendatahub.com/favicon.ico

Is some empty gray block.

Google is doing it better than us: https://www.google.com/favicon.ico

@dulvui can you fix this?

dulvui commented 9 months ago

The fav icon was already fixed on https://opendatahub.testingmachine.eu/favicon.ico by @sseppi It just needs to be deployed to production, but there are some changes on testingmachine I don't know if they are ready for production. If it is urgent, I can cherry-pick the commit with the fix to production. Should I wait for all changes in testing to go in production or cheery-pick the fix to production?

One strange thing is that on Firefox I get the NOI logo when visiting https://opendatahub.com/favicon.ico image

Anyway we should use the favicon from https://third-party.opendatahub.com/opendatahub-logo/OpenDataHub-favicon.png to be reuse compliant

ohnewein commented 9 months ago

Hi @dulvui , it is not super urgent, but I would suggest to not wait too long. If you can add it to your next sprint, that would be fine for me. Best regards, Patrick

sseppi commented 3 months ago

@ohnewein I think we can close this issue since the favicon is now working.