noi-techpark / opendatahub-website

0 stars 6 forks source link

As a Open Data Hub website visitor I want a anchor functionality in the Video Library section, to share a specific section or video with other people #240

Closed sseppi closed 3 months ago

sseppi commented 5 months ago

Since the number of sections and videos of the video library became quite large, it is difficult to find and share a specific video with other people.

https://opendatahub.com/events/video-library/

I wold like that a anchor functionality is added to the single page. This functionality should allow the user to share:

lukmay commented 4 months ago

Hi @sseppi . I implemented the changes here: PR I'm a bit unsure about the location of the JavaScript code. I also add a lot of comments to it so it's clear what it does.

https://github.com/noi-techpark/opendatahub-website/tree/anchor_links_videos Let me know if it is as you expected it to be👍

sseppi commented 4 months ago

Hi @lukmay ,

I collected the following feedback from Patrick:


This makes sharing on social media channels of the single videos impossible.

Expected behaviour

Can you please change the code of the page to fit what mentioned above?

lukmay commented 4 months ago

Hi @sseppi Thank you for sharing this feedback! I will make the enhancements and fixes when I'm back from vacation mid-next week. If this is more urgent and can't wait until next week, let me know and we will find a solution.

sseppi commented 3 months ago

@lukmay the anchor functionality seems to work fine now, I close the issue.