noi-techpark / opendatahub-website

0 stars 6 forks source link

Anchor links videos #243

Closed lukmay closed 2 months ago

lukmay commented 2 months ago

I implemented the enhancements suggested by @sseppi in this issue 240

dulvui commented 2 months ago

@lukmay Thank you Lukas for the contribution! I tried and it works, but when I try to open an anchor in a new browser, I always see the footer. By removing the JS code it works now, because settings the anchors is enough to make it work, no JS needed.

dulvui commented 2 months ago

Now it is live in testing, here an example: https://opendatahub.testingmachine.eu/events/video-library/#arxax-interview

It works but we have a fixed header, that overlays the video. I'll add now a some css to fix that issue too.

lukmay commented 2 months ago

@dulvui thank you for the review :) Did you also try to open anchor link of a video within a closed heading? If this works as well, you are right we will not need any js for it👍

dulvui commented 2 months ago

@lukmay oooh no I didn't see that there exist close headings, so your JS is actually needed. I think this can't work without JS. I'll try now to fix that too.

dulvui commented 2 months ago

@lukmay Now it works also with hidden sections, I moved your script to a own js file, here you can see the changes: https://github.com/noi-techpark/opendatahub-website/commit/96858706f761b1365b1d8de2fdb9487ff3234943

I only changed it a bit and removed the button click simulation to open the section and simply added the css class "show" to the section instead.

Here an example for a hidden video: https://opendatahub.testingmachine.eu/events/video-library/#environmental-data-platform-as-a-tool-for-working-with-heterogeneous-big-data