search

noi-techpark / webcomp-flightdata

GNU Affero General Public License v3.0
1 stars 2 forks source link

The filter attributes (airports and nations) do not work #25

Closed d3liaa closed 1 year ago

d3liaa commented 1 year ago

I copy and pasted the code from the webcomponent in a blank site to test it. To the default configurations i added the example filters from the README : 

  airports='["!HAM", "BER"]'
  nations='["DE"]'

but the results for arrivals and departures remained unvaried, thus showing results for Hamburg. I tried the other two examples as well but the results displayed never changed.

Maybe i made something wrong so this is the simple code i used inside the page:

<body style="width: 100%; height: 100%">
    <div style="width: 100%; height: 100%; padding:0 1.5rem">
<noi-mobility-atc arrivals="true" buyticket="false" departures="true" header="true" lang="en" map="true" maxage="60"
    maxforecast="5" metricunits="false" realtime="true" regionswitch="true" sidebar="true"
    theme="terminal" airports='["!HAM", "BER"]' nations='["DE"]'></noi-mobility-atc>
<script
    src="https://cdn.webcomponents.opendatahub.bz.it/dist/a15db41f-7483-46b4-ac0e-d63707c31059/noi-mobility-atc.min.js"></script>
    </div>
</body>

And this is the result (that never changed for the filters) Screenshot 2023-03-13 162110

mrabans commented 1 year ago

@dulvui can you please accept https://github.com/noi-techpark/webcomp-flightdata/pull/22 as it has a couple of improvments

mrabans commented 1 year ago

@d3liaa we'll verify

ag0n-e commented 1 year ago

@d3liaa Could it be that the component loaded from the CDN is still an old version? Since the last commits have not been merged into prod? @dulvui

dulvui commented 1 year ago

@ag0n-e Yes you are right. I merged now #22 and will put that directly into production. Let me know if everything works fine, then I'll put in production.

d3liaa commented 1 year ago

hi! @dulvui did you put it on production? Can i test if it works from the webcomp store?

dulvui commented 1 year ago

@d3liaa No I didn't put in production yet. You can test the webcomponent from the testing store and if everything is fine let me know, then I will deploy to production on Monday.

mrabans commented 1 year ago

All working for a while now. Closing issue.