search

noib3 / nvim-oxi

:link: Rust bindings to all things Neovim
https://crates.io/crates/nvim-oxi
MIT License
878 stars 43 forks source link

Fix Windows Dynamic Linking #147

Closed AregevDev closed 6 months ago

AregevDev commented 6 months ago

Hello,

Linking against the symbol definitions explicitly instead of using /force:unresolved fixes the segfaults. The examples work as expected. Note that the lib definitions, taken from a 0.9 source build, haven't been tested on a nightly NeoVim.

Fixes #125

noib3 commented 6 months ago

Could you remove the first 2 commits and cherry-pick 6c8c54a6c2e57d871bb6f211b0bc78945d892f73 to see if this fixes CI on Windows?

Also, what about this?

AregevDev commented 6 months ago

I removed the first two commits, I can't cherry-pick the commit you sent. I'll add the Windows CI to the build script and commit again.

melMass commented 6 months ago

Thanks I used the libs from an earlier version of this PR for echo, would this new refactoring do it at build time? I'm still trying to figure out how to properly bundle it. For now, I think I'll build all platforms in GH actions and use a build step in lazy to fetch the releases from Github, I'm not sure that's very common...

noib3 commented 6 months ago

Closed by #149.