search

noinnion / greader

gReader | Feedly | The Old Reader
http://noinnion.com/greader
234 stars 34 forks source link

Handle quotes in image alt text #383

Closed daughtkom closed 3 years ago

daughtkom commented 4 years ago

XKCD.com web comic puts an extra punchline in alt text of the image. Sometimes this caption contains quotes, and when it does it cannot be viewed.

noinnion commented 3 years ago

Could you send me an example?

daughtkom commented 3 years ago

I stopped using this app a year ago because of this, so I cannot reproduce it any more, but it's very to see for yourself. Subscribe to XKCD, then try to view the alt/title text of any day's comic in the reader app. The author regularly uses quotes in the hover text, so it shouldn't take long to find one with the issue, including yesterday's: https://xkcd.com/2424/.

noinnion commented 3 years ago

Unfortunately it is not possible fix it because of technical limitation. But thanks for your feedback.

daughtkom commented 3 years ago

I'm sure an appropriate call to string.replace(...) would do the trick. The quote character is escaped in the feed already:

image

It only needs to be unescaped before rendering.

Your app, your call, though. As I mentioned, I've already had to move on to another reader because this is broken (among other reasons).

Good luck getting back into it after several years. As a developer myself, I'm sure returning to an old project is not the most exciting thing on your plate.