search

noinnion / newsplus

News+ is a simple, fast and intuitive feed/rss reader for Android, featuring beautiful themes, podcast support and full offline support.
http://noinnion.com/newsplus
357 stars 77 forks source link

API - handler.startTime() should represent last successful sync #20

Closed asafge closed 11 years ago

asafge commented 11 years ago

When running a sync it might fail in the middle, but the handler.startTime() value is still updated. This make it's value unusable, because we might miss stories that are considered "old" even though they were never synced.

I think that the value should be reverted for every exception that comes from handleItemList, handleItemIdList.

noinnion commented 11 years ago

Actually it uses the last successful synchronization.

On Monday, August 5, 2013, Asaf Geva notifications@github.com wrote:

When running a sync it might fail in the middle, but the handler.startTime() value is still updated. This make it's value unusable, because we might miss stories that are considered "old" even though they were never synced.

I think that the value should be reverted for every exception that comes from handleItemList, handleItemIdList.

— Reply to this email directly or view it on GitHub.

asafge commented 11 years ago

I've seen at least one case where it wasn't. I will try and reproduce this.

asafge commented 11 years ago

I think this might happen when a sync takes too long, could you check?

noinnion commented 11 years ago

ok

On Tue, Aug 6, 2013 at 10:10 PM, Asaf Geva notifications@github.com wrote:

I think this might happen when a sync takes too long, could you check?

— Reply to this email directly or view it on GitHubhttps://github.com/noinnion/newsplus/issues/20#issuecomment-22207404 .