noinnion / newsplus

News+ is a simple, fast and intuitive feed/rss reader for Android, featuring beautiful themes, podcast support and full offline support.
http://noinnion.com/newsplus
349 stars 77 forks source link

Wide images not shrinking immediately during poor network connection #78

Closed moneytoo closed 9 years ago

moneytoo commented 9 years ago

I use News+ with TT-RSS (& Full-Text-RSS) for reading offline news when commuting. (In the past I used gReader with Google Reader)

In both cases I experience slight inconvenience - I use swipe left/right to move among articles but sometimes the article is wider and it takes few more swipes. I configured News+ to download full content and options "Image fit-to-width enabled" are on. Usually article images shrink in less than second but when I'm commuting on a subway, the network connection goes on and off every minute (and only 2G/Edge) and often it doesn't shrink even in 15 seconds so instead of waiting more (for some timeout probably), I just move on to the next article using more swipes. (The same articles fit width just fine when opening later outside of subway)

I'm not able to reliably duplicate the issue outside of subway. I don't have such problem with offline mode in TT-RSS Android client.

screenshot_2014-08-01-17-51-45

screenshot_2014-08-01-17-52-38

My settings:

<?xml version='1.0' encoding='utf-8' standalone='yes' ?>
<map>
    <string name="sync_interval_hours">1</string>
    <string name="rich_show_thumb">2</string>
    <boolean name="item_autoload_reading_mode" value="false" />
    <long name="com.asafge.pocketplus/.PocketPlus/last_sync_time" value="1403198638830" />
    <string name="offline_autoload_reading_mode">2</string>
    <boolean name="service_comment" value="false" />
    <boolean name="offline_autoload_cache" value="false" />
    <boolean name="use_phone_ui" value="false" />
    <null name="item_ids" />
    <boolean name="service_facebook" value="false" />
    <string name="item_user_agent">0</string>
    <string name="item_share_default">com.ideashower.readitlater.activity.AddActivity</string>
    <string name="cache_auto_clean_read">1</string>
    <string name="item_list_font_size">14</string>
    <boolean name="rich_article_list" value="true" />
    <string name="sync_auto_update">0</string>
    <boolean name="service_google_plus" value="false" />
    <string name="reader_login">com.noinnion.android.newsplus.extension.ttrss/.LoginActivity</string>
    <string name="service_tts">2</string>
    <boolean name="offline_save_data_traffic" value="false" />

    <boolean name="item_pinch_zoom" value="false" />
    <boolean name="reader_deletable_item" value="false" />
    <string name="offline_usage">1</string>
    <string name="item_load_link">0</string>
    <boolean name="confirm_mark_as_read_sub" value="false" />
    <boolean name="sync_server_reads" value="true" />
    <string name="sync_item_limit">1000</string>

    <string name="item_list_swipe_rtl">2</string>
    <boolean name="service_translate" value="false" />
    <string name="item_navigation_gesture">1</string>
    <boolean name="item_list_swipe_actions" value="false" />
    <boolean name="service_google_mobilizer" value="true" />
    <string name="item_list_left_action">0</string>
    <string name="service_tts_default_locale">eng-usa-</string>
    <string name="com.noinnion.android.newsplus.extension.ttrss/.TtRssExtension/reader_title">Tiny Tiny Rss</string>
    <string name="reader_title">Tiny Tiny Rss</string>
    <int name="item_font_type" value="0" />
    <boolean name="service_everclip" value="false" />
    <string name="item_images_loading">1</string>
    <int name="item_body_font_size" value="13" />
    <boolean name="confirm_mark_as_read_all" value="true" />
    <boolean name="item_inapp_youtube" value="true" />
    <boolean name="show_feeds_after_mark_all" value="false" />
    <boolean name="service_ril" value="true" />
    <int name="current_app" value="1" />
    <boolean name="home_landscape_dual_pane" value="true" />
    <boolean name="offline_load_video" value="false" />
    <boolean name="auto_hide_item_controls" value="false" />
    <boolean name="rich_show_snippet" value="true" />
    <boolean name="service_instapaper_mobilizer" value="true" />
    <int name="item_text_align" value="3" />
    <string name="sync_notify_sound_ringtone">content://settings/system/notification_sound</string>
    <boolean name="show_zoom_button" value="false" />

    <string name="offline_feed_items_limit">50</string>
    <string name="sync_notify_custom_sound_ringtone">content://settings/system/notification_sound</string>
    <boolean name="sync_notifiable_custom" value="false" />
    <string name="cache_auto_cleanup_images">1000</string>
    <boolean name="sync_notifiable" value="true" />
    <string name="offline_full_content_format">1</string>
    <boolean name="item_group_by_feed" value="false" />
    <boolean name="cache_keep_starred" value="true" />
    <int name="com.asafge.pocketplus/.PocketPlus/unread_count" value="0" />
    <string name="item_plugin_state">0</string>
    <string name="item_list_volume_key_action">1</string>
    <string name="db_cache_location">local</string>
    <string name="item_double_tap_action">9</string>
    <boolean name="grid_view" value="false" />
    <string name="item_nav_bar">1</string>
    <boolean name="offline_load_full_content" value="true" />
    <boolean name="item_view_inverse" value="false" />
    <string name="item_list_swipe_ltr">1</string>
    <string name="sync_on_start">0</string>
    <boolean name="service_readability" value="false" />
    <long name="next_interstitial_time" value="1403389347221" />
    <boolean name="offline_load_images" value="true" />
    <string name="application_theme">2</string>
    <string name="item_list_right_action">0</string>
    <boolean name="advanced_view" value="false" />
    <string name="item_send_to">1</string>
    <string name="com.asafge.pocketplus/.PocketPlus/reader_title">Pocket+</string>
    <string name="reader_component_name">com.noinnion.android.newsplus.extension.ttrss/.TtRssExtension</string>
    <boolean name="service_twitter" value="false" />
    <boolean name="hardware_accelerated" value="false" />
    <boolean name="show_navigation_bar" value="true" />
    <string name="item_volume_key_action">1</string>
    <string name="application_language"></string>
    <boolean name="cache_keep_cached" value="false" />
    <string name="cache_auto_clean_unread">-1</string>
    <long name="app_premium_check_time" value="1406915634222" />
    <boolean name="show_item_bar" value="true" />
    <boolean name="view_unread_only" value="true" />
    <long name="com.noinnion.android.newsplus.extension.ttrss/.TtRssExtension/last_sync_time" value="1406909480229" />
    <boolean name="offline_load_audio" value="false" />
    <boolean name="service_instapaper" value="false" />
    <boolean name="sync_include_starred" value="false" />
    <int name="com.noinnion.android.newsplus.extension.ttrss/.TtRssExtension/unread_count" value="20" />
    <boolean name="item_image_fit" value="true" />
    <boolean name="item_autoload_link" value="false" />

<subscription uid="FEED%3A-1" sync_excluded="false" hidden="false" notification="false" image_fit="true" javascript="true" offline_content="-1" display_content="-1" link_format="-1" auto_readability="-1" />
...
<subscription uid="FEED%3A1" sync_excluded="false" hidden="false" notification="false" image_fit="true" javascript="true" offline_content="-1" display_content="-1" link_format="-1" auto_readability="-1" />
<tag uid="CAT%3A1" label="Development" sync_excluded="false" hidden="false" />
...
<tag uid="CAT%3A0" label="Uncategorized" sync_excluded="false" hidden="false" />

</map>
noinnion commented 9 years ago

could you pls try the latest beta https://github.com/noinnion/newsplus/tree/master/beta

On Sat, Aug 2, 2014 at 12:17 AM, Marcel Dopita notifications@github.com wrote:

I use News+ with TT-RSS (& Full-Text-RSS) for reading offline news when commuting. (In the past I used gReader with Google Reader)

In both cases I experience slight inconvenience - I use swipe left/right to move among articles but sometimes the article is wider and it takes few more swipes. I configured News+ to download full content and options "Image fit-to-width enabled" are on. Usually article images shrink in less than second but when I'm commuting on a subway, the network connection goes on and off every minute (and only 2G/Edge) and often it doesn't shrink even in 15 seconds so instead of waiting more (for some timeout probably), I just move on to the next article using more swipes. (The same articles fit width just fine when opening later outside of subway)

I'm not able to reliably duplicate the issue outside of subway. I don't have such problem with offline mode in TT-RSS Android client.

[image: screenshot_2014-08-01-17-51-45] https://cloud.githubusercontent.com/assets/1071643/3785662/30990708-19c8-11e4-9899-debaa26d0537.png

[image: screenshot_2014-08-01-17-52-38] https://cloud.githubusercontent.com/assets/1071643/3785665/3f7f53d0-19c8-11e4-96a1-40d5eb9becf1.png

My settings:

<?xml version='1.0' encoding='utf-8' standalone='yes' ?>

1 2 2 0 com.ideashower.readitlater.activity.AddActivity 1 14 0 com.noinnion.android.newsplus.extension.ttrss/.LoginActivity 2 ``` 1 0 1000 2 1 0 eng-usa- Tiny Tiny Rss Tiny Tiny Rss 1 content://settings/system/notification_sound 50 content://settings/system/notification_sound 1000 1 0 1 local 9 1 1 0 2 0 1 Pocket+ com.noinnion.android.newsplus.extension.ttrss/.TtRssExtension 1 -1 ```

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/78.

moneytoo commented 9 years ago

Ok, will switch to beta and report then.

noinnion commented 9 years ago

The problem is that image fit could only apply after everthing has been downloaded. On Aug 2, 2014 9:07 AM, "Marcel Dopita" notifications@github.com wrote:

Ok, will switch to beta and report then.

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/78#issuecomment-50956126.

moneytoo commented 9 years ago

In the settings I have already chosen to download everything. I also works fine offline.

noinnion commented 9 years ago

sometimes there are items that need to be loaded. not everything can be saved for offline. You can see the loading with the blue line.

On Sun, Aug 3, 2014 at 8:23 AM, Marcel Dopita notifications@github.com wrote:

In the settings I have already chosen to download everything. I also works fine offline.

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/78#issuecomment-50983131.

moneytoo commented 9 years ago

I understand and I thought that it's something like that. However looking at an article (last in http://feeds.feedburner.com/blackberry/CAxx), there's no JS or tracking, just few links and images. Maybe I could find out more from logcat or network capture if it's type of non cached resource causing this.

noinnion commented 9 years ago

are the images cached? could you send me a screenshot from the feed?

On Sun, Aug 3, 2014 at 5:04 PM, Marcel Dopita notifications@github.com wrote:

I understand and I thought that it's something like that. However looking at an article (last in http://feeds.feedburner.com/blackberry/CAxx), there's no JS or tracking, just few links and images. Maybe I could find out more from logcat or network capture if it's type of non cached resource causing this.

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/78#issuecomment-50992772.

moneytoo commented 9 years ago

I tried few more times and was able to replicate the issue only on the first try (I switched to 2G and it took few seconds until offline feed article loaded with all four images). I will make snapshots of cache to compare agains real world usage. I also had "Load full content" on so I will try that off as I don't really need it.

moneytoo commented 9 years ago

shots Seems like it's the feed icon which doesn't cache and causes this...

noinnion commented 9 years ago

yeah it could be the site icon On Aug 4, 2014 7:33 PM, "Marcel Dopita" notifications@github.com wrote:

[image: shots] https://cloud.githubusercontent.com/assets/1071643/3800810/eaac1dd4-1bfc-11e4-830d-4666e6322642.jpg Seems like it's the feed icon which doesn't cache and causes this...

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/78#issuecomment-51090995.

moneytoo commented 9 years ago

v1.1.5 fixes it. Thanks!