noinnion / newsplus

News+ is a simple, fast and intuitive feed/rss reader for Android, featuring beautiful themes, podcast support and full offline support.
http://noinnion.com/newsplus
356 stars 77 forks source link

ttrss "starred" status not being updated by News+ #88

Open TwoBytes opened 9 years ago

TwoBytes commented 9 years ago

If I star or unstar an item in News+, the starred status doesn't sync back to ttrss.

Items that are already starred in ttrss via a different method (web interface or another ttrss mobile app) appear as starred in News+, but if I unstar or star an item in News+, it is reset to whatever the server status is on the next sync.

noinnion commented 9 years ago

try to go to the starred folder and sync from there

On Mon, Jan 19, 2015 at 10:55 PM, TwoBytes notifications@github.com wrote:

If I star or unstar an item in News+, the starred status doesn't sync back to ttrss.

Items that are already starred in ttrss via a different method (web interface or another ttrss mobile app) appear as starred in News+, but if I unstar or star an item in News+, it is reset to whatever the server status is on the next sync.

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/88.

TwoBytes commented 9 years ago

If I select Starred items from the drop-down, it says "Tag not found", so I can't sync from there

TwoBytes commented 9 years ago

I'm guessing that my issue might be related to the fact that I get "Tag not found" when I go to starred items.

Could this be a ttrss server side issue?

The server was originally v1.7.9, but I've upgraded it to v1.15.3 (the latest at this time) and installed the News+ extension to see if it would fix this issue, but it hasn't made a difference.

Android apps "Tiny Tiny RSS" and "TTRSS-Reader" both work fine with starred items (ie. I can star and un-star items and the star status syncs back to the server).

31SFX4 commented 9 years ago

It's working for me with 1.15.3. Can you check that you (re-)installed the ttrss newsplus-api? When you update ttrss, it creates a new installation without any additional plugins. This caught me out several times when I updated ttrss and newsplus then didn't work properly.

Also make sure that "include starred articles" is set in the sync settings in NewsPlus.

TwoBytes commented 9 years ago

Hi smatthie, thanks for the response.

I actually installed the newsplus-api plugin after I upgraded to v1.15.3, so it's definitely there. I'm pretty sure it's working, because the sync is quicker than it was before

I turned on "include starred articles", and it gave me a messages that it had synced 199 more items, so it's doing something, but it still says "tag not found" when I click on "Starred items".

The strangest thing is that it works fine in several other Android clients, so I don't think it's an issue with the server.

I might try setting up a new server instance of tt-rss to see if that's the problem.

This is driving me crazy!

TwoBytes commented 9 years ago

The plot thickens...

I created a new empty MySQL database with the ttrss schema and pointed my existing ttrss instance at it.

With the fresh database, News+ syncs and displays starred items properly.

(News+ had a heart-attack when I swapped the database out in the backend, but "force stop" and "clear cache" fixed that)

Troubleshooting continues...

Now I'm trying to figure out which setting in the OPML breaks News+'s star behaviour.

I found one other interesting thing... when stars are working, STARRED ITEMS in the feed list has a little star icon to the left, but when it's broken, there is a ">" instead.

TwoBytes commented 9 years ago

A bit more info on what I'm doing to replicate this behaviour...

I now have two OPML files, one exported from a completely fresh ttrss database, and one from my main database that News+ is having issues with.

I import the OPML file through the ttrss web interface, then clear the News+ cache and resynch to get it to display the behaviour.

I have removed all the feed info from both OPML files, so it's just settings.

If I import the "broken" OPML...

If I import the "fixed" OPML...

These are the only settings that are different between the two OPML files (these settings are from the working one)...

      <outline pref-name="AUTO_ASSIGN_LABELS" value="false"/>'
      <outline pref-name="CDM_EXPANDED" value="true"/>
      <outline pref-name="DEFAULT_UPDATE_INTERVAL" value="30"/>
      <outline pref-name="ENABLE_FEED_CATS" value="true"/>
      <outline pref-name="FRESH_ARTICLE_MAX_AGE" value="24"/>
      <outline pref-name="PURGE_OLD_DAYS" value="60"/>
      <outline pref-name="PURGE_UNREAD_ARTICLES" value="true"/>
      <outline pref-name="USER_TIMEZONE" value="Automatic"/>
      <outline pref-name="_DEFAULT_VIEW_MODE" value="adaptive"/>
      <outline pref-name="_DEFAULT_VIEW_ORDER_BY" value="default"/>
      <outline pref-name="_ENABLED_PLUGINS" value=""/>

This is those same lines from the "broken" one...

      <outline pref-name="AUTO_ASSIGN_LABELS" value="true"/>
      <outline pref-name="CDM_EXPANDED" value="false"/>
      <outline pref-name="DEFAULT_UPDATE_INTERVAL" value="15"/>
      <outline pref-name="ENABLE_FEED_CATS" value="false"/>
      <outline pref-name="FRESH_ARTICLE_MAX_AGE" value="10000"/>
      <outline pref-name="PURGE_OLD_DAYS" value="0"/>
      <outline pref-name="PURGE_UNREAD_ARTICLES" value="false"/>
      <outline pref-name="USER_TIMEZONE" value="Australia/Canberra"/>
      <outline pref-name="_DEFAULT_VIEW_MODE" value="all_articles"/>
      <outline pref-name="_DEFAULT_VIEW_ORDER_BY" value="feed_dates"/>
      <outline pref-name="_ENABLED_PLUGINS" value="import_export"/>

Nothing in there jumps out to me as being obviously crazy, so I'm going to go through and add in one line at a time to see exactly what's breaking it.

Here's the full "broken" OPML file if anybody else wants to see if they can replicate the behaviour...

<?xml version="1.0" encoding="utf-8"?>
<opml version="1.0">
  <head>
    <dateCreated>Fri, 30 Jan 2015 10:43:30 +0000</dateCreated>
    <title>Tiny Tiny RSS Feed Export</title>
  </head>
  <body>
    <outline text="tt-rss-prefs" schema-version="126">
      <outline pref-name="ALLOW_DUPLICATE_POSTS" value="false"/>
      <outline pref-name="AUTO_ASSIGN_LABELS" value="true"/>
      <outline pref-name="BLACKLISTED_TAGS" value="main, generic, misc, uncategorized, blog, blogroll, general, news"/>
      <outline pref-name="CDM_AUTO_CATCHUP" value="false"/>
      <outline pref-name="CDM_EXPANDED" value="false"/>
      <outline pref-name="COMBINED_DISPLAY_MODE" value="true"/>
      <outline pref-name="CONFIRM_FEED_CATCHUP" value="true"/>
      <outline pref-name="DEFAULT_ARTICLE_LIMIT" value="30"/>
      <outline pref-name="DEFAULT_UPDATE_INTERVAL" value="15"/>
      <outline pref-name="DIGEST_CATCHUP" value="false"/>
      <outline pref-name="DIGEST_ENABLE" value="false"/>
      <outline pref-name="DIGEST_PREFERRED_TIME" value="00:00"/>
      <outline pref-name="ENABLE_API_ACCESS" value="true"/>
      <outline pref-name="ENABLE_FEED_CATS" value="false"/>
      <outline pref-name="FEEDS_SORT_BY_UNREAD" value="false"/>
      <outline pref-name="FRESH_ARTICLE_MAX_AGE" value="10000"/>
      <outline pref-name="HIDE_READ_FEEDS" value="false"/>
      <outline pref-name="HIDE_READ_SHOWS_SPECIAL" value="true"/>
      <outline pref-name="LONG_DATE_FORMAT" value="D, M d Y - G:i"/>
      <outline pref-name="ON_CATCHUP_SHOW_NEXT_FEED" value="false"/>
      <outline pref-name="PURGE_OLD_DAYS" value="0"/>
      <outline pref-name="PURGE_UNREAD_ARTICLES" value="false"/>
      <outline pref-name="REVERSE_HEADLINES" value="false"/>
      <outline pref-name="SHORT_DATE_FORMAT" value="M d, G:i"/>
      <outline pref-name="SHOW_CONTENT_PREVIEW" value="true"/>
      <outline pref-name="SORT_HEADLINES_BY_FEED_DATE" value="false"/>
      <outline pref-name="SSL_CERT_SERIAL" value=""/>
      <outline pref-name="STRIP_IMAGES" value="false"/>
      <outline pref-name="STRIP_UNSAFE_TAGS" value="true"/>
      <outline pref-name="USER_CSS_THEME" value="default.css"/>
      <outline pref-name="USER_LANGUAGE" value="auto"/>
      <outline pref-name="USER_STYLESHEET" value=""/>
      <outline pref-name="USER_TIMEZONE" value="Australia/Canberra"/>
      <outline pref-name="VFEED_GROUP_BY_FEED" value="false"/>
      <outline pref-name="_COLLAPSED_FEEDLIST" value="false"/>
      <outline pref-name="_COLLAPSED_LABELS" value="false"/>
      <outline pref-name="_COLLAPSED_SPECIAL" value="false"/>
      <outline pref-name="_COLLAPSED_UNCAT" value="false"/>
      <outline pref-name="_DEFAULT_INCLUDE_CHILDREN" value="false"/>
      <outline pref-name="_DEFAULT_VIEW_LIMIT" value="30"/>
      <outline pref-name="_DEFAULT_VIEW_MODE" value="all_articles"/>
      <outline pref-name="_DEFAULT_VIEW_ORDER_BY" value="feed_dates"/>
      <outline pref-name="_ENABLED_PLUGINS" value="import_export"/>
      <outline pref-name="_MOBILE_BROWSE_CATS" value="true"/>
      <outline pref-name="_MOBILE_ENABLE_CATS" value="false"/>
      <outline pref-name="_MOBILE_HIDE_READ" value="false"/>
      <outline pref-name="_MOBILE_REVERSE_HEADLINES" value="false"/>
      <outline pref-name="_MOBILE_SHOW_IMAGES" value="false"/>
      <outline pref-name="_MOBILE_SORT_FEEDS_UNREAD" value="false"/>
      <outline pref-name="_PREFS_ACTIVE_TAB" value=""/>
      <outline pref-name="_PREFS_SHOW_EMPTY_CATS" value="false"/>
      <outline pref-name="_THEME_ID" value="0"/>
    </outline>
    <outline text="tt-rss-labels" schema-version="126"/>
    <outline text="tt-rss-filters" schema-version="126"/>
  </body>
</opml>

TwoBytes commented 9 years ago

And the full "Fixed" OPML file, in case you imported the "Broken" one and want to get it back again!

<?xml version="1.0" encoding="utf-8"?>
<opml version="1.0">
  <head>
    <dateCreated>Sat, 31 Jan 2015 03:23:32 +0000</dateCreated>
    <title>Tiny Tiny RSS Feed Export</title>
  </head>
  <body>
    <outline text="tt-rss-prefs" schema-version="126">
      <outline pref-name="ALLOW_DUPLICATE_POSTS" value="false"/>
      <outline pref-name="AUTO_ASSIGN_LABELS" value="false"/>
      <outline pref-name="BLACKLISTED_TAGS" value="main, generic, misc, uncategorized, blog, blogroll, general, news"/>
      <outline pref-name="CDM_AUTO_CATCHUP" value="false"/>
      <outline pref-name="CDM_EXPANDED" value="true"/>
      <outline pref-name="COMBINED_DISPLAY_MODE" value="true"/>
      <outline pref-name="CONFIRM_FEED_CATCHUP" value="true"/>
      <outline pref-name="DEFAULT_ARTICLE_LIMIT" value="30"/>
      <outline pref-name="DEFAULT_UPDATE_INTERVAL" value="30"/>
      <outline pref-name="DIGEST_CATCHUP" value="false"/>
      <outline pref-name="DIGEST_ENABLE" value="false"/>
      <outline pref-name="DIGEST_PREFERRED_TIME" value="00:00"/>
      <outline pref-name="ENABLE_API_ACCESS" value="true"/>
      <outline pref-name="ENABLE_FEED_CATS" value="true"/>
      <outline pref-name="FEEDS_SORT_BY_UNREAD" value="false"/>
      <outline pref-name="FRESH_ARTICLE_MAX_AGE" value="24"/>
      <outline pref-name="HIDE_READ_FEEDS" value="false"/>
      <outline pref-name="HIDE_READ_SHOWS_SPECIAL" value="true"/>
      <outline pref-name="LONG_DATE_FORMAT" value="D, M d Y - G:i"/>
      <outline pref-name="ON_CATCHUP_SHOW_NEXT_FEED" value="false"/>
      <outline pref-name="PURGE_OLD_DAYS" value="60"/>
      <outline pref-name="PURGE_UNREAD_ARTICLES" value="true"/>
      <outline pref-name="REVERSE_HEADLINES" value="false"/>
      <outline pref-name="SHORT_DATE_FORMAT" value="M d, G:i"/>
      <outline pref-name="SHOW_CONTENT_PREVIEW" value="true"/>
      <outline pref-name="SORT_HEADLINES_BY_FEED_DATE" value="false"/>
      <outline pref-name="SSL_CERT_SERIAL" value=""/>
      <outline pref-name="STRIP_IMAGES" value="false"/>
      <outline pref-name="STRIP_UNSAFE_TAGS" value="true"/>
      <outline pref-name="USER_CSS_THEME" value="default.css"/>
      <outline pref-name="USER_LANGUAGE" value="auto"/>
      <outline pref-name="USER_STYLESHEET" value=""/>
      <outline pref-name="USER_TIMEZONE" value="Automatic"/>
      <outline pref-name="VFEED_GROUP_BY_FEED" value="false"/>
      <outline pref-name="_COLLAPSED_FEEDLIST" value="false"/>
      <outline pref-name="_COLLAPSED_LABELS" value="false"/>
      <outline pref-name="_COLLAPSED_SPECIAL" value="false"/>
      <outline pref-name="_COLLAPSED_UNCAT" value="false"/>
      <outline pref-name="_DEFAULT_INCLUDE_CHILDREN" value="false"/>
      <outline pref-name="_DEFAULT_VIEW_LIMIT" value="30"/>
      <outline pref-name="_DEFAULT_VIEW_MODE" value="adaptive"/>
      <outline pref-name="_DEFAULT_VIEW_ORDER_BY" value="default"/>
      <outline pref-name="_ENABLED_PLUGINS" value=""/>
      <outline pref-name="_MOBILE_BROWSE_CATS" value="true"/>
      <outline pref-name="_MOBILE_ENABLE_CATS" value="false"/>
      <outline pref-name="_MOBILE_HIDE_READ" value="false"/>
      <outline pref-name="_MOBILE_REVERSE_HEADLINES" value="false"/>
      <outline pref-name="_MOBILE_SHOW_IMAGES" value="false"/>
      <outline pref-name="_MOBILE_SORT_FEEDS_UNREAD" value="false"/>
      <outline pref-name="_PREFS_ACTIVE_TAB" value=""/>
      <outline pref-name="_PREFS_SHOW_EMPTY_CATS" value="false"/>
      <outline pref-name="_THEME_ID" value="0"/>
    </outline>
    <outline text="tt-rss-labels" schema-version="126"/>
    <outline text="tt-rss-filters" schema-version="126"/>
  </body>
</opml>
TwoBytes commented 9 years ago

I figured it out...

Importing this line in an OPML file... <outline pref-name="ENABLE_FEED_CATS" value="false"/> Breaks News+, but ONLY after clearing the cache and re-synching

So obviously, going into preferences and unticking "Enable feed categories" also breaks it (after clearing the News+ cache and re-synching)

I'm not sure if this is an easy fix. None of the other ttrss Android clients I've used have this problem, so hopefully that means it's possible.

I would prefer not to have categories enabled, because now all my feed are rolled up under "Uncategorised", which I need to expand every time, but that's a whole lot better than having a year's worth of "stars" silently ignored!

31SFX4 commented 9 years ago

I can confirm this. I had feed cats enabled, and now disabled them to test your idea. Worked at first, but after clearing the cache it didn't sync starred items any more (no starred articles at all on News+). Enabling cat and it works again.

TwoBytes commented 9 years ago

Thanks for taking the time to verify my issue smatthie!

Like I said, it would be great to get this fixed, but it's a very small annoyance now, compared to the major showstopper it was before I figured it out.

noinnion commented 9 years ago

the problem is that if ENABLE_FEED_CATS is disabled. Starred tag is not created on News+. So syncing is not possible for starred items. Maybe I should add it manually.

On Mon, Feb 2, 2015 at 4:49 AM, TwoBytes notifications@github.com wrote:

Thanks for taking the time to verify my issue smatthie!

Like I said, it would be great to get this fixed, but it's a very small annoyance now, compared to the major showstopper it was before I figured it out.

— Reply to this email directly or view it on GitHub https://github.com/noinnion/newsplus/issues/88#issuecomment-72403138.

31SFX4 commented 9 years ago

Can I ask: is "starred" in News+ handled like an article tags? I'm asking because there is also an issue that tags are not synchronised with ttrss, which may be related.