search

noir-clojure / lib-noir

A set of libraries for ring apps, including stateful sessions.
Eclipse Public License 1.0
481 stars 47 forks source link

wrap-rewrites #54

Closed amalloy closed 11 years ago

amalloy commented 11 years ago

I couldn't figure out your test files within five seconds of looking at them, so I played around in the repl instead of writing a test.

Raynes commented 11 years ago

That's okay, @yogthos will write tests. He compulsively does so.

(I DEMAND IT) (okay, you don't have to if you don't feel like it)

yogthos commented 11 years ago

I'll write some tests... :P

ebaxt commented 11 years ago

If you are interested, I have already written an almost complete port of rack-rewrite: https://github.com/ebaxt/ring-rewrite If not, you can still use some of the tests I believe.

Cheers

Raynes commented 11 years ago

Thanks for the heads up, @ebaxt! This particular piece of middleware is simple enough that I think it's reasonable to have it around and if it doesn't do enough for people using lib-noir, we can point them at your library. We'll definitely look at the tests, that might be very helpful.