noir-clojure / lib-noir

A set of libraries for ring apps, including stateful sessions.
Eclipse Public License 1.0
479 stars 47 forks source link

lib-luminus merges #7

Closed yogthos closed 11 years ago

yogthos commented 11 years ago

I think I got all of it moved over reasonably ok, and tested locally here so nothing should be borked. I also moved the markdown-clj stuff into the template as promised.

once we get this merged, I'll update the template and lib-lum can die off quietly :)

yogthos commented 11 years ago

so how should we do it, you want me to just make the fixes and just open a new pull request or is there an easier way?

Raynes commented 11 years ago

Any commits you make on this branch (your master branch) will appear here and update the pull request. Github is cool like that.

yogthos commented 11 years ago

awesometastic! :)

so let's recap

I'll add a noir.request namespace and shove request there then noir.response, noir.util.middleware, and noir.util.route will reference it

and update the redirect to look like this:

(defn redirect
  ([url] (redirect url :permanent *request*))
  ([url type] (redirect url type *request*))
  ([url type request] (dostuff)))

then the refactoring for io stuff to simply take a string and replace the slashes on it

anything I missed?

Raynes commented 11 years ago

Sounds about right to me.

yogthos commented 11 years ago

ok should be close now :)

Raynes commented 11 years ago

Ding ding ding, we have a winner.

yogthos commented 11 years ago

success! :)