Closed yogthos closed 11 years ago
so how should we do it, you want me to just make the fixes and just open a new pull request or is there an easier way?
Any commits you make on this branch (your master branch) will appear here and update the pull request. Github is cool like that.
awesometastic! :)
so let's recap
I'll add a noir.request namespace and shove request there then noir.response, noir.util.middleware, and noir.util.route will reference it
and update the redirect to look like this:
(defn redirect
([url] (redirect url :permanent *request*))
([url type] (redirect url type *request*))
([url type request] (dostuff)))
then the refactoring for io stuff to simply take a string and replace the slashes on it
anything I missed?
Sounds about right to me.
ok should be close now :)
Ding ding ding, we have a winner.
success! :)
I think I got all of it moved over reasonably ok, and tested locally here so nothing should be borked. I also moved the markdown-clj stuff into the template as promised.
once we get this merged, I'll update the template and lib-lum can die off quietly :)