noir-lang / acvm

Apache License 2.0
46 stars 16 forks source link

Remove `prove_with_meta` and `verify_from_cs` #139

Closed phated closed 1 year ago

phated commented 1 year ago

Problem

@vezenovm said we don't use prove_with_meta and verify_from_cs anymore. We should remove them from the ProofSystemCompiler trait so we don't need to implement them in backends.

Proposed solution

Remove them, as they are already marked as deprecated.

Alternatives considered

No response

Additional context

Ref https://github.com/noir-lang/aztec_backend/pull/82

TomAFrench commented 1 year ago

Yep, these were deprecated in 0.5.0 so removal in 0.7.0 fits Kev's "deprecation -> removal" schedule.

The only other currently developed backend that I know of (gnark) supports the pk/vk methods so no reason to keep this around.