search

noir-lang / acvm

Apache License 2.0
46 stars 16 forks source link

Rename `Split` Directive to `BinaryDecomposition` #36

Closed kevaundray closed 1 year ago

kevaundray commented 1 year ago

Problem

Currently split is not a descriptive name for what the directive is doing.

Solution

Rename Split to Binary decomposition or a more descriptive name.

Alternatives considered

(Describe any alternative solutions you have considered.)

Additional context

(If applicable.)

vezenovm commented 1 year ago

I assigned this issue to myself as I have PR noir-lang/noir#543 open currently and I could rename it in there. However, this is a fast fix and I don't think it will require the backend upgrades that the to_bytes PR requires, so if someone wants to make a PR that does this rename before the to_bytes PR is ready, feel free to do so.

kevaundray commented 1 year ago

I think its better to do this as a separate PR as a general rule of thumb