search

noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
824 stars 178 forks source link

Resolve mem2reg TODO in `check_array_aliasing` #2478

Open jfecher opened 10 months ago

jfecher commented 10 months ago

Aim

check_array_aliasing currently doesn't differentiate between an array containing references and an array containing an array which has references.

Expected Behavior

It is unclear whether this is an important distinction, but it seems wrong to treat them both the same way.

Note that this handling would no longer be needed if #1733 is implemented.

Bug

This could possibly (?) lead to bugs when using nested arrays of arrays which contain references.

To Reproduce

1. 2. 3. 4.

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

Savio-Sou commented 8 months ago

Assuming this is no longer relevant as https://github.com/noir-lang/noir/issues/1733 was implemented.

TomAFrench commented 8 months ago

This todo still exists.