Bring nested recursion example into noir-lang/noir

noir-lang / noir

Noir is a domain specific language for zero knowledge proofs

https://noir-lang.org

Apache License 2.0

874 stars 189 forks source link

Bring nested recursion example into noir-lang/noir #4410

Open Savio-Sou opened 7 months ago

Savio-Sou commented 7 months ago

### Prerequisites
- [ ] https://github.com/AztecProtocol/dev-rel/pull/207

jzaki commented 5 months ago

Details from Tom:

[x] A top-level examples would also be fine for now (later docs/examples with docs moved to docs/site)
[x] Remove use of codegen command
[x] We'll need to have them pull the dependencies from the workspace rather than being fixed to a particular npm version.
- If we're referencing the package.json in the docs then we're going to need to swap out the dependencies for the npm versions when pushing a new release.
[x] We're going to need to run these as part of CI so we can enforce that the code still works and we can fix as needed.

Savio-Sou commented 4 months ago

Following https://github.com/noir-lang/noir/pull/5072, proving and verification workflow would be scoped out of NoirJS.

The PR includes updates to the doc page. Commenting here for @noir-lang/developerrelations and readers' awareness in case it leads to changes to existing / planned works with respect to this Issue.

critesjosh commented 3 months ago

if not done by the end of the week, moving to blocked

jzaki commented 3 months ago

Yeah, issue relayed again to Noir team. Now blocked until workaround/fix found.

Savio-Sou commented 3 months ago

@jzaki could you link me to the relevant noir-lang/noir or AztecProtocol/aztec-packages Issue?

jzaki commented 3 months ago

Okay, with a little tip form Tom, I did get it to pass, but by doing something that seems wrong and different to between what nargo returns and bb expects between binary vs js. I'll check with Tom this morning and create an issue for the lack of intuition on the .js side to document, or an issue for the .js side to be aligned with the binaries' way.

jzaki commented 2 months ago

Added two benchmark circuits from Savio, 2^17 succeeds, 2^18 fails. The recursion test is skipped. PR here

Once 2^18 works again, the skipped recursion tests should readily be made to pass again, so can unskip it and remove the benchmark tests.

Savio-Sou commented 2 months ago

Thanks @jzaki.

2^18 fails

If you have time it might be good to file an Issue for it in https://github.com/AztecProtocol/aztec-packages.