noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
821 stars 177 forks source link

fix: Don't lazily elaborate functions #5282

Closed jfecher closed 1 week ago

jfecher commented 2 weeks ago

Description

Problem*

Resolves https://github.com/noir-lang/noir/issues/5271

Summary*

Lazily elaborating functions wasn't correct since the FuncMeta object never stored the LocalModuleId carried by the set of unresolved functions. This lead to lazily elaborated functions be elaborated in a different module than intended.

Additional Context

Lazily elaborated functions seem to no longer be necessary to run our tests, nor to run the tests in aztec-nr so I've just removed them rather than adding the additional fields to FuncMeta.

Documentation*

Check one:

PR Checklist*