noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
821 stars 177 forks source link

chore: `static_assert` error message fix and split into is-dynamic and is-false #5353

Closed michaeljklein closed 2 days ago

michaeljklein commented 2 days ago

Description

Fix static_assert error message

Problem*

Error message for static_assert was ~"Argument to static_assert is false or dynamic" at some point, but currently is copy/pasted from the nested slices error

Summary*

Additional Context

Documentation*

Check one:

PR Checklist*

TomAFrench commented 2 days ago

Seems like we should be able to determine which case we've encountered. It would be nice to for devs to be able to tell if they have a false or just undecidable assertion.

michaeljklein commented 2 days ago

@TomAFrench sure, can add that 👍