search

noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
858 stars 185 forks source link

Add tests for noir-bignum and noir-rsa in `external-repo-checks` #5627

Closed Savio-Sou closed 43 minutes ago

Savio-Sou commented 1 month ago

Problem

noir-bignum and noir_rsa are receiving and making growing attention and impact to community projects.

We should maintain the libraries well, but they are not currently tested against Noir master to flag related breaking changes.

Happy Case

Add tests for the libraries in external-repo-checks to proactively flag Noir changes that will break the libraries, prompting library updates necessary to work with new Noir versions.

Project Impact

Nice-to-have

Would you like to submit a PR for this Issue?

None

Support Needs

No response

vezenovm commented 3 weeks ago

We should maintain the libraries well, but they are not currently tested against Noir master to flag related breaking changes.

We had turned off the external_repo_checks as any breaking changes would give a big red X on our PRs that are actually valid and pass our CI. I think these types of checks against Noir nightlies should be done on the libraries themselves.