noir-lang / noir

Noir is a domain specific language for zero knowledge proofs

https://noir-lang.org

Apache License 2.0

872 stars 188 forks source link

fix: Always parse all tokens from quoted token streams #6064

Closed jfecher closed 2 weeks ago

jfecher commented 2 weeks ago

Description

Problem*

Resolves https://github.com/noir-lang/noir/issues/5803 Resolves https://github.com/noir-lang/noir/issues/6059

Summary*

If we ever had a token stream with a subset of valid input we'd parse just that subset instead of erroring that the full input doesn't parse.

Additional Context

We don't have EOF tokens in token streams so I used the end() primitive instead.

Documentation*

Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions[bot] commented 2 weeks ago

Changes to Brillig bytecode sizes

Generated at commit: f567aafd753627fd2c5b1ff51110218d5d206d51, compared to commit: 052c4fe52a4df9d6492f9b0d6b449151b87b18d5

There are no changes in circuit sizes