noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
895 stars 199 forks source link

test disallowed on impl methods seems to throw on structs #6535

Closed signorecello closed 2 hours ago

signorecello commented 2 hours ago

Aim

Trying to use the bignum library

Expected Behavior

I expect tests to not be executed or at least not throw errors

Bug

I get an error:

error: The `#[test]` attribute is disallowed on `impl` methods

To Reproduce

  1. Start a new project
  2. Import the bignum library
  3. Compile

Workaround

Yes

Workaround Description

Manually removing the make_tests macros makes it stop

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

TomAFrench commented 2 hours ago

This is expected behaviour and the library has been updated to not use these anymore.