search

noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
902 stars 203 forks source link

chore: redo typo PR by pucedoteth #6556

Closed TomAFrench closed 3 days ago

TomAFrench commented 3 days ago

Thanks pucedoteth for https://github.com/noir-lang/noir/pull/6427. Our policy is to redo typo changes to dissuade metric farming. This is an automated script.

github-actions[bot] commented 3 days ago

Changes to Brillig bytecode sizes

Generated at commit: 2c805dc352b3d0b89e3774fe2a94016b8bbe6723, compared to commit: e1510ec248b2bc35a02ec14aac5af4a20ee3caf7

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
databus_two_calldata_simple +36 ❌ +44.44%
databus +28 ❌ +41.79%
databus_composite_calldata +151 ❌ +38.13%
databus_two_calldata +44 ❌ +19.73%
sha256 -546 ✅ -20.55%
regression_mem_op_predicate -24 ✅ -21.62%
closures_mut_ref -7 ✅ -23.33%
loop -27 ✅ -26.47%
array_dynamic_main_output -24 ✅ -26.67%
bit_shifts_runtime -119 ✅ -45.08%
Full diff report 👇
| Program | Brillig opcodes (+/-) | % | |:-|-:|-:| | **databus_two_calldata_simple** | 117 (+36) | **+44.44%** | | **databus** | 95 (+28) | **+41.79%** | | **databus_composite_calldata** | 547 (+151) | **+38.13%** | | **databus_two_calldata** | 267 (+44) | **+19.73%** | | **nested_array_dynamic** | 2,552 (+407) | **+18.97%** | | **if_else_chain** | 114 (+15) | **+15.15%** | | **regression_3607** | 49 (+5) | **+11.36%** | | **conditional_regression_421** | 90 (+9) | **+11.11%** | | **bigint** | 2,244 (+199) | **+9.73%** | | **binary_operator_overloading** | 421 (+35) | **+9.07%** | | **break_and_continue** | 61 (+5) | **+8.93%** | | **brillig_cow** | 430 (+31) | **+7.77%** | | **aes128_encrypt** | 557 (+35) | **+6.70%** | | **nested_array_in_slice** | 1,344 (+65) | **+5.08%** | | **simple_shift_left_right** | 28 (+1) | **+3.70%** | | **hash_to_field** | 154 (+5) | **+3.36%** | | **sha256_var_witness_const_regression** | 1,442 (+37) | **+2.63%** | | **6** | 1,405 (+36) | **+2.63%** | | **conditional_regression_short_circuit** | 1,475 (+36) | **+2.50%** | | **conditional_regression_661** | 130 (+3) | **+2.36%** | | **sha256_var_padding_regression** | 5,374 (+120) | **+2.28%** | | **array_dynamic** | 337 (+7) | **+2.12%** | | **regression_4449** | 878 (+18) | **+2.09%** | | **sha256_var_size_regression** | 2,089 (+41) | **+2.00%** | | **slice_dynamic_index** | 2,962 (+58) | **+2.00%** | | **ram_blowup_regression** | 1,030 (+20) | **+1.98%** | | **generics** | 212 (+4) | **+1.92%** | | **sha256_regression** | 7,411 (+133) | **+1.83%** | | **ecdsa_secp256k1** | 1,032 (+18) | **+1.78%** | | **array_dynamic_blackbox_input** | 1,196 (+15) | **+1.27%** | | **array_dynamic_nested_blackbox_input** | 1,010 (+12) | **+1.20%** | | **6_array** | 438 (+5) | **+1.15%** | | **slice_loop** | 352 (+3) | **+0.86%** | | **conditional_1** | 1,362 (+8) | **+0.59%** | | **tuple_inputs** | 377 (+2) | **+0.53%** | | **modulus** | 1,777 (+5) | **+0.28%** | | **eddsa** | 11,189 (+30) | **+0.27%** | | **u128** | 2,920 (+5) | **+0.17%** | | **poseidonsponge_x5_254** | 4,506 (+6) | **+0.13%** | | **poseidon_bn254_hash_width_3** | 5,696 (+6) | **+0.11%** | | **poseidon_bn254_hash** | 5,696 (+6) | **+0.11%** | | **brillig_cow_regression** | 2,424 (-1) | **-0.04%** | | **higher_order_functions** | 739 (-2) | **-0.27%** | | **regression_5252** | 4,902 (-14) | **-0.28%** | | **strings** | 1,039 (-3) | **-0.29%** | | **slices** | 2,304 (-14) | **-0.60%** | | **7_function** | 639 (-4) | **-0.62%** | | **keccak256** | 1,782 (-12) | **-0.67%** | | **uhashmap** | 17,067 (-132) | **-0.77%** | | **regression_capacity_tracker** | 239 (-2) | **-0.83%** | | **sha2_byte** | 3,410 (-41) | **-1.19%** | | **pedersen_commitment** | 197 (-3) | **-1.50%** | | **hashmap** | 28,151 (-535) | **-1.87%** | | **import** | 146 (-3) | **-2.01%** | | **brillig_unitialised_arrays** | 47 (-1) | **-2.08%** | | **regression_struct_array_conditional** | 558 (-12) | **-2.11%** | | **schnorr** | 1,460 (-32) | **-2.14%** | | **array_sort** | 306 (-7) | **-2.24%** | | **array_to_slice** | 1,028 (-25) | **-2.37%** | | **simple_shield** | 870 (-27) | **-3.01%** | | **brillig_pedersen** | 745 (-27) | **-3.50%** | | **pedersen_check** | 745 (-27) | **-3.50%** | | **fold_complex_outputs** | 596 (-22) | **-3.56%** | | **regression** | 726 (-27) | **-3.59%** | | **brillig_rc_regression_6123** | 191 (-8) | **-4.02%** | | **no_predicates_numeric_generic_poseidon** | 811 (-37) | **-4.36%** | | **fold_numeric_generic_poseidon** | 811 (-37) | **-4.36%** | | **merkle_insert** | 778 (-36) | **-4.42%** | | **poseidon2** | 365 (-17) | **-4.45%** | | **bench_2_to_17** | 358 (-17) | **-4.53%** | | **integer_array_indexing** | 59 (-3) | **-4.84%** | | **fold_2_to_17** | 629 (-34) | **-5.13%** | | **signed_arithmetic** | 255 (-16) | **-5.90%** | | **3_add** | 47 (-3) | **-6.00%** | | **derive** | 136 (-9) | **-6.21%** | | **pedersen_hash** | 358 (-24) | **-6.28%** | | **references** | 292 (-22) | **-7.01%** | | **1_mul** | 62 (-5) | **-7.46%** | | **reference_only_used_as_alias** | 284 (-33) | **-10.41%** | | **missing_closure_env** | 22 (-3) | **-12.00%** | | **tuples** | 46 (-7) | **-13.21%** | | **nested_dyn_array_regression_5782** | 148 (-24) | **-13.95%** | | **array_if_cond_simple** | 110 (-24) | **-17.91%** | | **sha256** | 2,111 (-546) | **-20.55%** | | **regression_mem_op_predicate** | 87 (-24) | **-21.62%** | | **closures_mut_ref** | 23 (-7) | **-23.33%** | | **loop** | 75 (-27) | **-26.47%** | | **array_dynamic_main_output** | 66 (-24) | **-26.67%** | | **bit_shifts_runtime** | 145 (-119) | **-45.08%** |
github-actions[bot] commented 3 days ago

Changes to circuit sizes

Generated at commit: 2c805dc352b3d0b89e3774fe2a94016b8bbe6723, compared to commit: e1510ec248b2bc35a02ec14aac5af4a20ee3caf7

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
debug_logs +6 ❌ +15.00% +54 ❌ +284.21%
hashmap +38,328 ❌ +148.52% +72,998 ❌ +112.41%
bit_shifts_runtime +600 ❌ +67.72% +783 ❌ +16.67%
sha256 +148 ❌ +8.55% -3,639 ✅ -14.59%
references -4 ✅ -40.00% -5 ✅ -19.23%
conditional_1 -1,994 ✅ -32.43% -4,825 ✅ -28.81%
regression_5252 -97,584 ✅ -73.83% -130,183 ✅ -73.08%
Full diff report 👇
| Program | ACIR opcodes (+/-) | % | Circuit size (+/-) | % | |:-|-:|-:|-:|-:| | **debug_logs** | 46 (+6) | **+15.00%** | 73 (+54) | **+284.21%** | | **hashmap** | 64,134 (+38,328) | **+148.52%** | 137,938 (+72,998) | **+112.41%** | | **bit_shifts_runtime** | 1,486 (+600) | **+67.72%** | 5,481 (+783) | **+16.67%** | | **sha2_byte** | 20,042 (+4,102) | **+25.73%** | 93,749 (+11,068) | **+13.39%** | | **binary_operator_overloading** | 402 (+118) | **+41.55%** | 4,615 (+150) | **+3.36%** | | **ram_blowup_regression** | 173,523 (+19,199) | **+12.44%** | 676,864 (+17,663) | **+2.68%** | | **sha256_var_witness_const_regression** | 1,675 (+307) | **+22.44%** | 17,216 (+388) | **+2.31%** | | **nested_array_dynamic** | 3,166 (-115) | **-3.51%** | 12,930 (+280) | **+2.21%** | | **hash_to_field** | 582 (+75) | **+14.79%** | 3,618 (+69) | **+1.94%** | | **u16_support** | 189 (+40) | **+26.85%** | 3,042 (+51) | **+1.71%** | | **aes128_encrypt** | 127 (-16) | **-11.19%** | 1,643 (+20) | **+1.23%** | | **bigint** | 1,166 (+81) | **+7.47%** | 8,117 (+74) | **+0.92%** | | **regression** | 141 (+24) | **+20.51%** | 3,683 (+28) | **+0.77%** | | **nested_array_in_slice** | 883 (-58) | **-6.16%** | 5,503 (+30) | **+0.55%** | | **u128** | 680 (+25) | **+3.82%** | 4,689 (+24) | **+0.51%** | | **slices** | 835 (+48) | **+6.10%** | 3,947 (+15) | **+0.38%** | | **regression_mem_op_predicate** | 56 (+9) | **+19.15%** | 3,586 (+10) | **+0.28%** | | **array_if_cond_simple** | 108 (+6) | **+5.88%** | 3,132 (+7) | **+0.22%** | | **conditional_regression_661** | 29 (+5) | **+20.83%** | 2,796 (+4) | **+0.14%** | | **regression_3607** | 39 (+2) | **+5.41%** | 2,802 (+4) | **+0.14%** | | **schnorr** | 1,519 (+6) | **+0.40%** | 23,932 (+26) | **+0.11%** | | **conditional_2** | 21 (+2) | **+10.53%** | 2,781 (+3) | **+0.11%** | | **conditional_regression_short_circuit** | 370 (0) | **0.00%** | 11,155 (+1) | **+0.01%** | | **fold_basic** | 4 (-1) | **-20.00%** | 17 (0) | **0.00%** | | **eddsa** | 64,629 (-2) | **-0.00%** | 65,815 (-2) | **-0.00%** | | **sha256_var_padding_regression** | 3,812 (-6) | **-0.16%** | 193,935 (-6) | **-0.00%** | | **ecdsa_secp256k1** | 488 (-2) | **-0.41%** | 43,516 (-2) | **-0.00%** | | **array_dynamic_blackbox_input** | 1,360 (-2) | **-0.15%** | 21,404 (-2) | **-0.01%** | | **bench_eddsa_poseidon** | 16,439 (-2) | **-0.01%** | 19,586 (-2) | **-0.01%** | | **array_dynamic_nested_blackbox_input** | 246 (-1) | **-0.40%** | 7,314 (-1) | **-0.01%** | | **regression_4449** | 8,477 (-70) | **-0.82%** | 285,214 (-70) | **-0.02%** | | **bench_sha256** | 182 (-2) | **-1.09%** | 7,053 (-2) | **-0.03%** | | **simple_comparison** | 23 (-1) | **-4.17%** | 3,495 (-1) | **-0.03%** | | **5_over** | 20 (-1) | **-4.76%** | 3,488 (-1) | **-0.03%** | | **6** | 342 (-4) | **-1.16%** | 11,126 (-4) | **-0.04%** | | **3_add** | 11 (-1) | **-8.33%** | 2,772 (-1) | **-0.04%** | | **field_attribute** | 4 (-1) | **-20.00%** | 2,763 (-1) | **-0.04%** | | **bench_sha256_30** | 5,199 (-60) | **-1.14%** | 124,621 (-60) | **-0.05%** | | **bench_sha256_100** | 17,309 (-200) | **-1.14%** | 408,399 (-200) | **-0.05%** | | **bit_shifts_comptime** | 10 (-3) | **-23.08%** | 2,841 (-3) | **-0.11%** | | **signed_arithmetic** | 184 (-4) | **-2.13%** | 2,933 (-4) | **-0.14%** | | **regression_capacity_tracker** | 113 (-4) | **-3.42%** | 3,964 (-8) | **-0.20%** | | **side_effects_constrain_array** | 8 (-5) | **-38.46%** | 2,767 (-6) | **-0.22%** | | **array_dynamic** | 102 (-4) | **-3.77%** | 3,714 (-14) | **-0.38%** | | **signed_cmp** | 63 (-2) | **-3.08%** | 231 (-2) | **-0.86%** | | **sha256_var_size_regression** | 16,161 (+4,188) | **+34.98%** | 70,961 (-981) | **-1.36%** | | **sha256_regression** | 35,090 (+14,664) | **+71.79%** | 197,460 (-3,115) | **-1.55%** | | **array_sort** | 53 (-2) | **-3.64%** | 128 (-4) | **-3.03%** | | **slice_dynamic_index** | 982 (-275) | **-21.88%** | 6,453 (-454) | **-6.57%** | | **poseidonsponge_x5_254** | 1,040 (-294) | **-22.04%** | 1,255 (-176) | **-12.30%** | | **sha256** | 1,878 (+148) | **+8.55%** | 21,307 (-3,639) | **-14.59%** | | **references** | 6 (-4) | **-40.00%** | 21 (-5) | **-19.23%** | | **conditional_1** | 4,154 (-1,994) | **-32.43%** | 11,924 (-4,825) | **-28.81%** | | **regression_5252** | 34,596 (-97,584) | **-73.83%** | 47,963 (-130,183) | **-73.08%** |
github-actions[bot] commented 3 days ago

Changes to number of Brillig opcodes executed

Generated at commit: 2c805dc352b3d0b89e3774fe2a94016b8bbe6723, compared to commit: e1510ec248b2bc35a02ec14aac5af4a20ee3caf7

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
bench_2_to_17 +144,061,619 ❌ +17056.67%
fold_2_to_17 +130,301,360 ❌ +8254.90%
databus +41 ❌ +50.00%
databus_two_calldata_simple +49 ❌ +42.24%
wildcard_type +195 ❌ +39.71%
regression_struct_array_conditional -920 ✅ -35.95%
reference_only_used_as_alias -163 ✅ -36.71%
regression_capacity_tracker -338 ✅ -37.02%
sha2_byte -40,496 ✅ -42.63%
array_if_cond_simple -234 ✅ -43.17%
Full diff report 👇
| Program | Brillig opcodes (+/-) | % | |:-|-:|-:| | **bench_2_to_17** | 144,906,225 (+144,061,619) | **+17056.67%** | | **fold_2_to_17** | 131,879,833 (+130,301,360) | **+8254.90%** | | **databus** | 123 (+41) | **+50.00%** | | **databus_two_calldata_simple** | 165 (+49) | **+42.24%** | | **wildcard_type** | 686 (+195) | **+39.71%** | | **databus_composite_calldata** | 762 (+147) | **+23.90%** | | **brillig_cow** | 1,288 (+137) | **+11.90%** | | **databus_two_calldata** | 491 (+38) | **+8.39%** | | **binary_operator_overloading** | 197 (+15) | **+8.24%** | | **nested_array_dynamic** | 3,301 (+184) | **+5.90%** | | **slice_loop** | 1,280 (+64) | **+5.26%** | | **simple_shift_left_right** | 24 (+1) | **+4.35%** | | **modulus** | 19,774 (+604) | **+3.15%** | | **if_else_chain** | 99 (+3) | **+3.13%** | | **aes128_encrypt** | 4,582 (+101) | **+2.25%** | | **u128** | 27,070 (+594) | **+2.24%** | | **generics** | 238 (+2) | **+0.85%** | | **hash_to_field** | 955 (+3) | **+0.32%** | | **6_array** | 1,845 (+5) | **+0.27%** | | **6** | 7,375 (+16) | **+0.22%** | | **conditional_regression_short_circuit** | 7,450 (+16) | **+0.22%** | | **tuple_inputs** | 637 (+1) | **+0.16%** | | **sha256_var_size_regression** | 18,354 (+21) | **+0.11%** | | **ecdsa_secp256k1** | 7,084 (+8) | **+0.11%** | | **sha256_regression** | 126,353 (+93) | **+0.07%** | | **sha256_var_witness_const_regression** | 7,041 (+3) | **+0.04%** | | **sha256_var_padding_regression** | 234,941 (+98) | **+0.04%** | | **regression_4449** | 219,902 (+79) | **+0.04%** | | **ram_blowup_regression** | 877,662 (+257) | **+0.03%** | | **higher_order_functions** | 1,518 (-2) | **-0.13%** | | **brillig_cow_regression** | 604,193 (-1,307) | **-0.22%** | | **strings** | 1,888 (-9) | **-0.47%** | | **7_function** | 2,812 (-35) | **-1.23%** | | **uhashmap** | 156,949 (-2,283) | **-1.43%** | | **eddsa** | 748,878 (-11,327) | **-1.49%** | | **nested_array_in_slice** | 1,531 (-25) | **-1.61%** | | **schnorr** | 10,184 (-168) | **-1.62%** | | **conditional_1** | 5,943 (-99) | **-1.64%** | | **references** | 421 (-9) | **-2.09%** | | **fold_numeric_generic_poseidon** | 6,508 (-154) | **-2.31%** | | **no_predicates_numeric_generic_poseidon** | 6,508 (-154) | **-2.31%** | | **brillig_unitialised_arrays** | 41 (-1) | **-2.38%** | | **poseidon2** | 849 (-22) | **-2.53%** | | **poseidonsponge_x5_254** | 197,277 (-5,283) | **-2.61%** | | **break_and_continue** | 111 (-3) | **-2.63%** | | **array_to_slice** | 2,367 (-64) | **-2.63%** | | **array_dynamic_nested_blackbox_input** | 4,511 (-122) | **-2.63%** | | **regression_5252** | 984,726 (-28,523) | **-2.82%** | | **pedersen_commitment** | 278 (-9) | **-3.14%** | | **integer_array_indexing** | 73 (-3) | **-3.95%** | | **array_dynamic_blackbox_input** | 48,284 (-2,308) | **-4.56%** | | **poseidon_bn254_hash** | 174,727 (-8,601) | **-4.69%** | | **poseidon_bn254_hash_width_3** | 174,727 (-8,601) | **-4.69%** | | **slices** | 3,882 (-234) | **-5.69%** | | **import** | 144 (-9) | **-5.88%** | | **hashmap** | 58,682 (-3,741) | **-5.99%** | | **derive** | 133 (-9) | **-6.34%** | | **signed_arithmetic** | 203 (-16) | **-7.31%** | | **3_add** | 37 (-3) | **-7.50%** | | **brillig_pedersen** | 1,135 (-99) | **-8.02%** | | **pedersen_check** | 1,135 (-99) | **-8.02%** | | **array_dynamic** | 505 (-50) | **-9.01%** | | **1_mul** | 50 (-5) | **-9.09%** | | **regression** | 2,821 (-294) | **-9.44%** | | **keccak256** | 37,079 (-3,904) | **-9.53%** | | **simple_shield** | 2,579 (-285) | **-9.95%** | | **brillig_rc_regression_6123** | 332 (-44) | **-11.70%** | | **pedersen_hash** | 575 (-90) | **-13.53%** | | **missing_closure_env** | 18 (-3) | **-14.29%** | | **slice_dynamic_index** | 4,658 (-807) | **-14.77%** | | **merkle_insert** | 3,356 (-603) | **-15.23%** | | **side_effects_constrain_array** | 70 (-14) | **-16.67%** | | **nested_dyn_array_regression_5782** | 129 (-38) | **-22.75%** | | **sha256** | 10,858 (-3,516) | **-24.46%** | | **tuples** | 32 (-11) | **-25.58%** | | **array_sort** | 546 (-194) | **-26.22%** | | **closures_mut_ref** | 19 (-7) | **-26.92%** | | **loop** | 137 (-59) | **-30.10%** | | **fold_complex_outputs** | 886 (-388) | **-30.46%** | | **bit_shifts_runtime** | 109 (-49) | **-31.01%** | | **array_dynamic_main_output** | 203 (-94) | **-31.65%** | | **regression_struct_array_conditional** | 1,639 (-920) | **-35.95%** | | **reference_only_used_as_alias** | 281 (-163) | **-36.71%** | | **regression_capacity_tracker** | 575 (-338) | **-37.02%** | | **sha2_byte** | 54,492 (-40,496) | **-42.63%** | | **array_if_cond_simple** | 308 (-234) | **-43.17%** |