noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
902 stars 203 forks source link

chore!: Require types of globals to be specified #6592

Closed michaeljklein closed 11 minutes ago

michaeljklein commented 19 hours ago

Description

Problem*

Resolves global type inference issues in https://github.com/noir-lang/noir/pull/6469/

Summary*

The approach in https://github.com/noir-lang/noir/pull/6469/ is to evaluate all globals as comptime globals, but that interacts poorly with polymorphic types, e.g. the type of x in let x = 3.

Additional Context

Documentation*

Check one:

PR Checklist*

github-actions[bot] commented 19 hours ago

🚀 Deployed on https://6740e461f74a113dddd143db--noir-docs.netlify.app

github-actions[bot] commented 18 minutes ago

FYI @noir-lang/developerrelations on Noir doc changes.