noir-lang / noir

Noir is a domain specific language for zero knowledge proofs
https://noir-lang.org
Apache License 2.0
913 stars 206 forks source link

Cleanup std::hash #6644

Open olehmisar opened 4 days ago

olehmisar commented 4 days ago

The list is not exhaustive

I am not sure about this:

olehmisar commented 2 days ago

my_hash(input: BoundedVec<u8, N>) may also be written as my_hash(input: impl Into<BoundedVec<u8, N>>), so it can accept both [u8; N] and BoundedVec<u8, N>.

Savio-Sou commented 12 hours ago

Hey @olehmisar thanks for submitting the Issue, this is a great collection of suggestions!

The team is currently occupied with gradually moving most of the hashing schemes currently in stdlib out to standalone repos (e.g. MiMC) as a part of https://github.com/noir-lang/noir/issues/6676.

They would be more able to chime in and share thoughts then 🙌 great to continue keep track of observations here for now!