noir-lang / vscode-noir

Apache License 2.0
6 stars 7 forks source link

VSCode Extension plugin not formatting on save (v0.0.11) #75

Closed jzaki closed 5 months ago

jzaki commented 6 months ago

Aim

Have .nr files autoformat on save

Expected Behavior

.nr files auto-format on save with noir-lang extension v0.0.11 as it does on v0.0.9

Bug

.nr files do not auto-format on save with noir-lang extension v0.0.11 as it does on v0.0.9

To Reproduce

  1. Open .nr file
  2. Make it un-pretty
  3. Save
  4. v0.0.11 does NOT format
  5. install version v0.0.9, save, does format .nr file

Environment

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

jzaki commented 6 months ago

@lang:noir settings (not general settings, not @ext setting) -> "format on save" defaults to on for the older version, and defaults to off for 0.0.11. Which appears to explain the difference between versions.

Savio-Sou commented 5 months ago

Solution: Check the general VS Code "Format On Save" setting.

Thanks @jzaki 🙏