search

noir-lang / vscode-noir

Apache License 2.0
6 stars 7 forks source link

Invalid reaction on adding some flags in Noir: Nargo Flags #79

Open aleee-ta opened 5 months ago

aleee-ta commented 5 months ago

Aim

Trying to add flag --print-acir (for example) in Noir: Nargo Flags field and see effect of this flag: image

Expected Behavior

See effect of this flag (fixed v): image

Bug

In current Marketplace version if I add flag in Noir: Nargo Flags I can see it: image

To Reproduce

//I have described my steps to reproduce the behavior

  1. Install nargo via noirup, code via apt
  2. Create project via nargo new
  3. Download extension in marketplace
  4. Open folder of your project in vscode
  5. Open extension settings
  6. Choose 'messages' in field Noir > Trace: Server to check commands
  7. Open Output in bottom panel
  8. Write in Noir: Nargo flags some flags
  9. Don't forget choose second instance of Noir Language Server in Output panel
  10. Enjoy image

Environment

OS: VM Lubuntu, WSL Ubuntu, etc Ext. version: 0.0.12

Additional Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

I think this bug from getLspCommand function from client.ts file, because of if I delete some strings, which find flags and insert them to args (nargo lsp don't have flags exclude --help), bug disappear.