Make async connections runtime controllable, with default from ifdef

noirello / bonsai

Simple Python 3 module for LDAP, using libldap2 and winldap C libraries.

MIT License

117 stars 33 forks source link

Make async connections runtime controllable, with default from ifdef #26

Closed tck42 closed 5 years ago

tck42 commented 5 years ago

Allows working around #25 - note that I'm new to native python extensions, not sure if I followed your style, and am unsure how to write a test for this.

noirello commented 5 years ago

Thanks the PR, really appreciate it. Yeah, testing this will be tricky. I added some notes to the changes.

I'll probably have some time to make these changes on the weekend. Also have to fix the testing environment on Travis. (As it seems the latest Fedora no longer compiles OpenLDAP with Mozilla NSS.)

tck42 commented 5 years ago

Agreed on all counts - I think I got it cleaned up, please let me know if I missed anything. Thanks!

noirello commented 5 years ago

Looks great, thanks. I'll check it out on the weekend and test it.

noirello commented 5 years ago

Thanks, I merged it into the dev branch, did some manual testing. Also I renamed the function to set_connect_async to be more aligned with the OpenLDAP option name.