search

noirello / bonsai

Simple Python 3 module for LDAP, using libldap2 and winldap C libraries.
MIT License
116 stars 32 forks source link

AttributeError while running tornado tests #67

Closed rjarry closed 1 year ago

rjarry commented 1 year ago

When running tests with tornado 6.2.0:

FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_add_and_delete - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_connection - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_modify_and_rename - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_obj_err - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_paged_search - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_paged_search_with_auto_acq - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_recursive_delete - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_search - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'
FAILED tests/test_tornado.py::TornadoLDAPConnectionTest::test_whoami - AttributeError: 'TornadoLDAPConnectionTest' object has no attribute 'should_close_asyncio_loop'

I have an easy fix.

noirello commented 1 year ago

I've just recently fixed it on the dev branch. (https://github.com/noirello/bonsai/commit/ccf9ce3ffb68680917ebfc977c1a65e3eccd122e)

noirello commented 1 year ago

1.5.0 is just released with the fix.