tests: fix attribute error with tornado 6.2.0

noirello / bonsai

Simple Python 3 module for LDAP, using libldap2 and winldap C libraries.

MIT License

116 stars 32 forks source link

tests: fix attribute error with tornado 6.2.0 #68

Closed rjarry closed 1 year ago

rjarry commented 1 year ago

Fix the following error when running tests with tornado 6.2.0:

>       if self.should_close_asyncio_loop:
E       AttributeError: 'TornadoLDAPConnectionTest' object has no
        attribute 'should_close_asyncio_loop'
/usr/lib/python3/dist-packages/tornado/testing.py:282: AttributeError

Since 6.2.0, tornado.AsyncTestCase.setUp() performs attributes initialization. It needs to be called by subclasses.

I did not bump the tornado version in pyproject.toml. Should I do so?

noirello commented 1 year ago

Already fixed with https://github.com/noirello/bonsai/commit/ccf9ce3ffb68680917ebfc977c1a65e3eccd122e on the dev branch.