noise-lab / netml

Feature Extraction and Machine Learning from Network Traffic Traces
Apache License 2.0
57 stars 17 forks source link

Fix: included both query and response for DNSRR packets #28

Closed staveesh closed 11 months ago

staveesh commented 11 months ago

The dns_resp column curently includes only the DNS query for the pcap2pandas function. This makes the function unusable for an analyst who is looking to match the DNS queries and responses to filter the traffic they're interested in. This PR fixes that by replacing scapy's dns_response.rrname by dns_response.rdata for the response, and a None query with dns_response.rrname. This will make filtering easy for an analyst without having to match the queries and responses.

Also included a couple lines in the parser example to test this out on a sample PCAP.