Issue calculating the number of packets

noise-lab / netml

Feature Extraction and Machine Learning from Network Traffic Traces

Apache License 2.0

54 stars 16 forks source link

Issue calculating the number of packets #8

Closed tarunmangla closed 1 year ago

tarunmangla commented 3 years ago

The line below calculates the number of packets in a flow. However, the pkts data structure is a 2-tuple w/ the first field being the flow id and the second field being the list of packets. So, it should be len(pkts[1]) instead of len(pkts) which is always 2.

https://github.com/chicago-cdac/netml/blob/d204074b6624cde5294d8de634c6df643c6523ef/src/netml/pparser/parser.py#L774

feamster commented 1 year ago

I also encountered this and pushed the bug fix. PR #11 @jesteria