search

noise-lab / netml

Feature Extraction and Machine Learning from Network Traffic Traces
Apache License 2.0
54 stars 16 forks source link

Issue with feature dimensions #9

Closed tarunmangla closed 1 year ago

tarunmangla commented 3 years ago

There seem to be two variables for the feature dimension: self.dim and dim. For calculating IAT features, only one of the variables is being updated. This leads to issues when appending header features.

https://github.com/chicago-cdac/netml/blob/d204074b6624cde5294d8de634c6df643c6523ef/src/netml/pparser/parser.py#L808

Should there be only one variable for consistency?

feamster commented 1 year ago

I also discovered this. It is the same issue as #8, fixed in the open PR.