search

noisebridge / pyclass-project

Other
8 stars 2 forks source link

Make "What Can I do" require login #44

Closed nbasu02 closed 12 years ago

nbasu02 commented 12 years ago

The views.py does not have an @login_required before it.

Belgand commented 12 years ago

Should it really require a login? It might be more sensible for logged-in users to get their interests (or whatever we end up deciding on) while users that aren't logged in will get some generic suggestions or just a list of all open and unclaimed tasks. This way it can engage more people without requiring an account... which might help encourage them to create an account.

nbasu02 commented 12 years ago

If anything, it should be the other way around. "What can I do" is a list of tasks tailored to the user, so if you're not logged in, nothing is tailored to you. The list of all tasks, however, could be potentially open to the public.

Belgand commented 12 years ago

But there's no harm in having it work for users that aren't logged in. It just won't have quite as many features. I think this better reflects Noisebridge by having almost everything publicly available (i.e. no login required) unless it actually needs it or you're creating data.

On Thu, May 31, 2012 at 7:05 PM, nbasu02 reply@reply.github.com wrote:

If anything, it should be the other way around.  "What can I do" is a list of tasks tailored to the user, so if you're not logged in, nothing is tailored to you.  The list of all tasks, however, could be potentially open to the public.

Reply to this email directly or view it on GitHub: https://github.com/noisebridge/pyclass-project/issues/44#issuecomment-6052158

nbasu02 commented 12 years ago

I think with proper filtering, the all-tasks is still more suited for this.

Belgand commented 12 years ago

I see your point, but that's pretty much the entire point of the link. It's basically just a quick way to access a common search pattern.