hzeller
commented
6 years ago Maybe we should separate the timing and doorbell options in one pull request and make the trusted philanthropist another one.
The first set can probably be easily merged. The other will conflict with https://github.com/noisebridge/rfid-access-control/commit/1a08324942a469d1982debf4e6b00f20a37db3b9 . So I suggest the second pull request with two commits: to revert change https://github.com/noisebridge/rfid-access-control/commit/1a08324942a469d1982debf4e6b00f20a37db3b9 in one commit, and another commit that adds https://github.com/noisebridge/rfid-access-control/pull/28/commits/17e4035dece9bac2d0c9d6d314db60772d9414ca which is r's better implementation of the concept.
All of the changes except the most recent ones should be able to be merged without any issues. IINM @rizend's most recent version implements the most recent consensus item on the subject of RFID changes, but doesn't yet include a way for members to upgrade philanthropists via the RFID terminal, so they must be added manually like philanthropists and members must be added.
https://www.noisebridge.net/wiki/Consensus_Items_History
Let Philanthropists Grant 30-day RFID Access
Consensus Item Date: 2018-10-23 Proposed By: R Consensus Item Text: 30-day daytime access to the space through the RFID access control system can be activated by Philanthropists (but the right for a philanthropist to give daytime access is granted by a member).
Extend RFID Hours to 10:00-23:00
Relevant meeting notes:
First discussed
R mentions they will be reploying