search

noiselabs / SmartyBundle

Smarty3 template engine bundle for Symfony
http://smartybundle.readthedocs.io/
GNU Lesser General Public License v3.0
51 stars 36 forks source link

Updates to the Assetic Extension #12

Closed ethanresnick closed 12 years ago

ethanresnick commented 12 years ago

Changes:

—Merged it into the main assets extension —Reformatted the code per symfony standards —Used some template helpers and parameters to integrate it into symfony more deeply and simplify configuration

vitorbrandao commented 12 years ago

Hi @studip101, thanks for contributing to SmartyBundle.

Why merge the AssetsExtensions and AsseticExtension? They serve different purposes and they come as two separated extensions in Symfony. I would like to keep them independent.

Developments on the AsseticExtension are being made on the assetic-extension branch. Would you please take a look at https://github.com/noiselabs/SmartyBundle/blob/assetic-extension/Extension/AsseticExtension.php? This is work in progress.

This extension was refactored and is now much closer to the extension provided by AsseticBundle for PHP and Twig. Support for stylesheets, javascripts and image blocks is included.

ethanresnick commented 12 years ago

Hi @noisebleed,

I didn't see the assetic-extension branch, otherwise I would've worked on that :)

And I agree that, ultimately, the two extensions should be separate (like in Symfony). I only merged them because the AsseticExtension's implementation I found in the main branch only had one method, so it didn't seem necessary to have a whole new extension for just that one method.

Anyway, is the AsseticExtension branch working now? What still needs to be done?

I'll close this PR.

vitorbrandao commented 12 years ago

I've announced this branch on issue #4, that requests this feature, and it's not on the frontpage README so it was easy to miss it. Sorry.

I need to add a loader and test it using assetic.use_controller. Looks like it is working for debug+!use_controller but I need to test it. I was planning to finish it this weekend but I'm completely busy with work till at least Tuesday. I'll get back to it then and report progress.

If you have comments and code to share please do so. I'll appreciate it.

vitorbrandao commented 12 years ago

@studip101 Did you give assetic-extension branch a try?

If you have feedback of any kind please report. I've never used assetic so I'm not sure what to expect from it. Also I'm short of free time these days...

ethanresnick commented 12 years ago

No, I didn't have a chance to look into it yet. I needed to get rolling with a project that was making extensive use of Assetic, so I decided to just bite the bullet and use twig. When that project's done I'll have a bit more free time and will take a look at this.