Closed gergelypolonkai closed 10 years ago
Hello @gergelypolonkai. Of course, that would be great. Please check this fork because I think @igorynia may already come up with a fix.
Pull Requests are more than welcome.
Thank you for pointing me out, I will check it!
Hello, @noisebleed! I modified actions rendering for backward compatibility, but I think better is to write new methods as in the twig bundle, what do you think?
@igorynia Can you please share a link to the twig class/method?
In sf 2.2 method "render" accepts the result of "controller" method, also added a few methods like "render_esi", "render_inline" or "render__renderingstrategy". Link https://github.com/symfony/symfony/blob/2.2/src/Symfony/Bridge/Twig/Extension/HttpKernelExtension.php. I don't know, how better it need to be done by smarty functions/modifiers.
Thanks. I'll take a look at it tonight or tomorrow night and merge your code or provide a new fix.
@igorynia Can you open a PR with your changes and send them in a branch named sf-2.2
or similar so I can work on top of it?
@noisebleed sorry, missed your response. Ok, I open a PR.
@igorynia I don't see any PR here. Have you created it already?
@noisebleed I don't see, how to pull in tag; can I PR to branch master?
Ok, I've PR in to master branch.
I think this issue can be closed.
It would be nice to use it with Symfony 2.2. For the first sight, it would require only a few modifications. I will try to test it tomorrow and send a patch if I can make it to work.