search

noiselabs / SmartyBundle

Smarty3 template engine bundle for Symfony
http://smartybundle.readthedocs.io/
GNU Lesser General Public License v3.0
51 stars 36 forks source link

3.0 release branch #74

Closed vitorbrandao closed 2 years ago

NielsJanssen commented 5 years ago

Hi, is this pull ready to be merged? I think it is, I've been using it in production for well over half a year now and I haven't encountered any issues so far :)

Only thing that seems to be holding back the tests is the PHP 5.6 support, which is EOL by now so it might be worth dropping support.

vitorbrandao commented 5 years ago

Hi @NielsJanssen. Thanks for the feedback! I'm going to drop 5.6 support and give it another try.

vitorbrandao commented 2 years ago

Changes included in this pull request have now been incorporated in the master branch via another PR. I've used a different branch so I could rebase and apply changes cleanly without affecting this PR and its branch alias which is being picked by Packagist (3.0.x-dev).

vitorbrandao commented 2 years ago

Changes included in this pull request have now been incorporated in the master branch via another PR. I've used a different branch so I could rebase and apply changes cleanly without affecting this PR and its branch alias which is being picked by Packagist (3.0.x-dev).

cc @NielsJanssen