noiseorchestra / jacktrip_pypatcher

Python scripts to autopatch a JackTrip hubserver
GNU General Public License v3.0
6 stars 1 forks source link

Distorted audio being sent back to clients #47

Closed sandreae closed 4 years ago

sandreae commented 4 years ago

Just finished another test session with 4 musicians and experienced a lot of audio distortion in the mix coming back from the server. It's hard to pinpoint exactly where it's happening, but it's fair to say we need more headroom. Apart from this the general audio quality was great and we didn't notice any latency issues. The session setup was as so:

locations: London, Manchester, Newcastle, Carmarthen clients: 4 x musicians connecting with ANU client jacktrip audio channels: some stereo, some mono

observations:

Screenshot from 2020-10-06 12-44-23

It seems the accumulation of signals into each client mix is causing distortion to occur when it's patched back into JackTrip to be sent back to the client. This is being exaggerated by the way that JackTrip (mis)handles the audio when peaks occur.

suggestions:

sandreae commented 4 years ago

I can do a PR for the ladspa changes if you think that's worth a go :+1:

madwort commented 4 years ago

the overflow fix just got merged into main jacktrip branch, should be in the next release (whenever that is)

sandreae commented 4 years ago

the overflow fix just got merged into main jacktrip branch, should be in the next release (whenever that is)

Amazing!

sandreae commented 4 years ago

I think that only solves half of our issue though right? As in, we don't want it to peak in the first place...

sandreae commented 4 years ago

Worth saying that this would also be solved if everyone just turned down ;-p however in the session today it was again clear that it's hard to get that balance sometimes (and if you're the one with the strong signal, you won't hear the distortion in your mix), so probably good to minimise chances of this happening on the server. Good to know your thoughts on this too though as you have a deeper understanding of the JackTrip side of things.

madwort commented 4 years ago

I think that only solves half of our issue though right? As in, we don't want it to peak in the first place...

yep yep

sandreae commented 4 years ago

the overflow fix just got merged into main jacktrip branch, should be in the next release (whenever that is)

Also, whoop! #officialjacktripdev

sandreae commented 4 years ago

Closing because we have various solutions to explore, it's a semi-ongoing problem more related to use of the system than the system itself.

madwort commented 4 years ago

still no new upstream jacktrip release, I think - a bit annoying...! easy to roll our own for linux, but it would be good to have a new macOS client for people not yet on ANU...